Starry Eyed Surprise - need help fixing theme

[Slothsin]

This is what I changed the code to:

Code: [Select]

%X|BG2.bmp|
%x|a|song.bmp|0|114|
%x|b|artist.bmp|0|127|
%x|c|album.bmp|0|140|
%xl|d|stop.bmp|265|163|
%xl|e|play.bmp|265|163|
%xl|f|pause.bmp|265|163|
%xl|g|ff.bmp|265|163|
%xl|h|rw.bmp|265|163|
%xl|i|rptnone.bmp|15|0|
%xl|j|rptall.bmp|15|0|
%xl|k|rptone.bmp|15|0|
%xl|l|rptshuf.bmp|15|0|
%xl|m|rptab.bmp|15|0|
%xl|n|hold.bmp|30|0|
%xl|o|none.bmp|30|0|
%xl|p|disk.bmp|45|0|
%xl|q|none.bmp|45|0|
%xl|r|battery.bmp|280|0|
%xl|s|volume.bmp|280|12|
%xl|t|vol0.bmp|225|114|
%xl|u|vol1.bmp|225|114|
%xl|v|vol2.bmp|225|114|
%xl|w|vol3.bmp|225|114|
%xl|x|vol4.bmp|225|114|
%xl|y|vol5.bmp|225|114|
%xl|z|vol6.bmp|225|114|
%xl|A|vol7.bmp|225|114|
%xl|B|vol8.bmp|225|114|
%xl|C|batt1.bmp|290|0|
%xl|D|batt2.bmp|290|0|
%xl|E|batt3.bmp|290|0|
%xl|F|batt4.bmp|290|0|
%xl|G|batt5.bmp|290|0|
%?mp<%xdd|%xde|%xdf|%xdg|%xdh>%?mm<%xdi|%xdj|%xdk|%xdl|%xdm>%?mh<%xdn|%xdo>%?lh<%xdp|%xdq>%ac%ar%bl 
%V|290|320|-|-|1|-|-|%pv






%s%V|16|140|-|-|1|-|-|%?it<%it|%?fn<%fn|Unknown Title>>
%s%V|16|140|-|-|1|-|-|%?ia<%ia|%?d2<%d2|Unknown Artist>>
%s%V|16|140|-|-|1|-|-|%?id<%id|%?d1<%d1|Unknown Album>>
%pb|progress.bmp|6|2|140|-|
%V|0|320|-|-|1|-|-| %pc%ar%pr                                                            
%s|0|140|  Next:;  %t5%?It<%It|%Fn>;   %t3%?Ia<%Ia|%?D2<%D2|Unknown Artist>>;   %t3%?Id<%Ia|%?D1<%D1|Unknown Album>>

%V|0|320|-|-|1|-|-|%ac___________________________________
%V|0|320|-|-|1|-|-|%ac%cl:%cM %cp %ca, %cb %cd, %cY
%?pv<%xdt|%xdu|%xdv|%xdw|%xdx|%xdy|%xdz|%xdA|%xdB>
%?bl<%xdC|%xdE|%xdF|%xdG>
%C
%Cl|5|2|100|100|

The main changes, like everyone has mentioned, I removed %p and changed the %pb syntax accordingly. I've replaced %m with %V...however, it's still not working properly. Maybe I'm misunderstanding the viewport code.

Any help would be appreciated.

[JdGordon]

a few things that are immediatly noticable as wrong...
1) you cant put anything at the end of the %V line, it will be ignored
2)viewports are used to say "put the following text into this rectangle... and keep it in this rectangle untill a new viewport is defined
so it should be
%V|16|140|-|-|1|-|-|
%s%?it<%it|%?fn<%fn|Unknown Title>>
%s%?ia<%ia|%?d2<%d2|Unknown Artist>>
etc...

3)reread the viewport info on the CustomWPS wiki page.... the first 2 numbers are the x and y pixel value... you have 0,320 which would use the bottom pixel row  (and would actually have no room to draw anything)

4) %Cl is usually put at the beginning of the WPS (although i doubt that would matter much)

[Slothsin]

Ok, I tried what you said, although I don't exactly understand how to choose the location:

%wd
%X|BG2.bmp|
%x|a|song.bmp|0|114|
%x|b|artist.bmp|0|127|
%x|c|album.bmp|0|140|
%xl|d|stop.bmp|265|163|
%xl|e|play.bmp|265|163|
%xl|f|pause.bmp|265|163|
%xl|g|ff.bmp|265|163|
%xl|h|rw.bmp|265|163|
%xl|i|rptnone.bmp|15|0|
%xl|j|rptall.bmp|15|0|
%xl|k|rptone.bmp|15|0|
%xl|l|rptshuf.bmp|15|0|
%xl|m|rptab.bmp|15|0|
%xl|n|hold.bmp|30|0|
%xl|o|none.bmp|30|0|
%xl|p|disk.bmp|45|0|
%xl|q|none.bmp|45|0|
%xl|r|battery.bmp|280|0|
%xl|s|volume.bmp|280|12|
%xl|t|vol0.bmp|225|114|
%xl|u|vol1.bmp|225|114|
%xl|v|vol2.bmp|225|114|
%xl|w|vol3.bmp|225|114|
%xl|x|vol4.bmp|225|114|
%xl|y|vol5.bmp|225|114|
%xl|z|vol6.bmp|225|114|
%xl|A|vol7.bmp|225|114|
%xl|B|vol8.bmp|225|114|
%xl|C|batt1.bmp|290|0|
%xl|D|batt2.bmp|290|0|
%xl|E|batt3.bmp|290|0|
%xl|F|batt4.bmp|290|0|
%xl|G|batt5.bmp|290|0|
%?mp<%xdd|%xde|%xdf|%xdg|%xdh>%?mm<%xdi|%xdj|%xdk|%xdl|%xdm>%?mh<%xdn|%xdo>%?lh<%xdp|%xdq>%ac%ar%bl
%V|290|320|-|-|1|-|-|
%pv






%V|16|140|-|-|1|-|-|
%s%?it<%it|%?fn<%fn|Unknown Title>>
%s%?ia<%ia|%?d2<%d2|Unknown Artist>>
%s%?id<%id|%?d1<%d1|Unknown Album>>
%pb|progress.bmp|6|2|140|-|
%V|0|320|-|-|1|-|-|
%pc%ar%pr                                                           
%s|0|140|  Next:;  %t5%?It<%It|%Fn>;   %t3%?Ia<%Ia|%?D2<%D2|Unknown Artist>>;   %t3%?Id<%Ia|%?D1<%D1|Unknown Album>>

%V|0|320|-|-|1|-|-|
%ac___________________________________
%V|0|320|-|-|1|-|-|
%ac%cl:%cM %cp %ca, %cb %cd, %cY
%?pv<%xdt|%xdu|%xdv|%xdw|%xdx|%xdy|%xdz|%xdA|%xdB>
%?bl<%xdC|%xdE|%xdF|%xdG>
%C
%Cl|5|2|100|100|

[JdGordon]

choose what location? and whats the problem your having?

[PaulJam]

Hi,

if you have trouble finding the correct coordinates and dimensions for the viewports, you can find them out easily using the simple paint program that comes with Windows:

Load the backdrop image or a screendump of the WPS in paint and then use the selection tool to mark the area where the viewport should be. As long as you keep the left mouse button pressed you see the correct numbers (already in the correct order) in the status bar.

So in the attached example the viewport definition for the selected area would be:
%V|5|12|210|37|1|-|-|

[Slothsin]

JdGordan:

Well, PaulJam's idea is pretty helpful (thanks btw), so that answer your first question.

The problem I'm having is that the display on the play screen for the starry eyed theme is reverting to the rockbox default one. And I've read that it's due to the a syntax error. I've been trying to fix it and the attempts are posted. The 2nd revision still doesn't work so I'm not sure where other syntax errors are.

[PaulJam]

You can find on what line in the .wps file the error is by loading the WPS in a Rocbox UI-simulator. You can find precompiled versions for various targets here:
http://rasher.dk/rockbox/simulator/
It shows the line of the first error in the console output and it is also a nice tool to preview the WPS.

I'm quite convinced that the WPS doesn't work because of the viewport definitions. They use 320 as y-coordinate but this is outside of the screen area. The coordinate values start at 0, so only values from 0 to 319 are legal for the y-coordinate on a 320 pixel high screen.
So please rework the viewports (and i would highly suggest to take care that the viewports don't overlap)

Have you already read the CustomWPS page?
http://www.rockbox.org/twiki/bin/view/Main/CustomWPS

[Slothsin]

Yes, I have read it.

But I didn't really change much in terms of the original file because I was assuming that under the old syntax, it was still correct. However, I never tried editting the WPS files until this new version of RockBox, so I don't know what the old %m command did. Anyway, I'll definitely try what you're suggesting today and post a success (hopefully) or failure

Also, part of the reason I've been having so much trouble was because I was not aware of the simulator. And obviously its a pain to load and reload stuff on the actual Ipod. I found it 2 days ago...so go figure.

[PaulJam]

However, I never tried editting the WPS files until this new version of RockBox, so I don't know what the old %m command did.

You can find the description what the %m tag did by looking at an older version of the CustomWPS page:
http://www.rockbox.org/twiki/bin/view/Main/CustomWPS?rev=107#Margin

The numeric value of the %m tag in the old version of the WPS should be the x coordinate of the viewport in which the line is in the updated WPS.

[BdN3504]

I fixed the theme. here's the working code.

Code: [Select]

#Starry Eyed Surprise WPS for iPod 5G
#by Gary Light (evilG123)
#Background image from Deviant Art, otherwise everything is GPL
%wd
%X|BG2.bmp|
%x|a|song.bmp|0|114|
%x|b|artist.bmp|0|127|
%x|c|album.bmp|0|140|
%xl|d|stop.bmp|265|163|
%xl|e|play.bmp|265|163|
%xl|f|pause.bmp|265|163|
%xl|g|ff.bmp|265|163|
%xl|h|rw.bmp|265|163|
%xl|R|repeat.bmp|297|216|5|
%xl|t|vol0.bmp|225|114|
%xl|u|vol1.bmp|225|114|
%xl|v|vol2.bmp|225|114|
%xl|w|vol3.bmp|225|114|
%xl|x|vol4.bmp|225|114|
%xl|y|vol5.bmp|225|114|
%xl|z|vol6.bmp|225|114|
%xl|A|vol7.bmp|225|114|
%xl|B|vol8.bmp|225|114|
%xl|C|batt1.bmp|290|0|
%xl|D|batt2.bmp|290|0|
%xl|E|batt3.bmp|290|0|
%xl|F|batt4.bmp|290|0|
%xl|G|batt5.bmp|290|0|
%pb|progress.bmp|2|159|134|4|

%?pv<%xdt|%xdu|%xdv|%xdw|%xdx|%xdy|%xdz|%xdA|%xdB>
%?bl<%xdC|%xdE|%xdF|%xdG>
%C
%Cl|5|2|100|100|
%?mp<%xdd|%xde|%xdf|%xdg|%xdh>%?mm<%xdRa|%xdRb|%xdRc|%xdRd|%xdRe>%?mh<%xdn|%xdo>%?lh<%xdp|%xdq>
%V|289|13|31|13|1|-|-|
V:%pv 

%V|16|114|119|39|1|-|-|
%t2%?it<%it|%?fn<%fn|Unknown Title>>  ;%t8%s%?it<%it|%?fn<%fn|Unknown Title>>;
%t2%?ia<%ia|%?d2<%d2|Unknown Artist>> ;%t8%s%?ia<%ia|%?d2<%d2|Unknown Artist>>;
%t2%?id<%id|%?d1<%d1|Unknown Album>>  ;%t8%s%?id<%id|%?d1<%d1|Unknown Album>>;
%V|3|170|136|12|1|-|-|
%pc%ar%pr
%V|6|184|129|13|1|-|-|
%sNext:;  %t5%?It<%It|%Fn>;   %t3%?Ia<%Ia|%?D2<%D2|Unknown Artist>>;   %t3%?Id<%Ia|%?D1<%D1|Unknown Album>>

%V|76|207|172|14|1|-|-|
___________________________________
%V|76|222|172|18|1|-|-|
%ac%cl:%cM %cp %ca, %cb %cd, %cY

I have created an additional image for repeat states.

the volume bar is indicated as a pitchmeter on the turntable. i think that this gives people wrong ideas, espacially in our modernday times. i can picture a guy with an ipod and this theme walking into a record store listening to some music surprised that the music sounds weird, when all he wanted to do was to increase the volume.
I tried to change the conditional showing the volume into the pitch setting but that did not work. i will post this in the feature request section.

EDIT: Download the repeatstate image here!
put it into the wps folder of this theme.

[Slothsin]

Thanks a bunch.

For the additional repeat.bmp, could you email me those files? PM me, and I'll give you my email