Use multiple progress bars with conditional Viewports

[BdN3504]

Correect me if i'm wrong, but the commit which changed the wps syntax also introduced the feature to display three different progress bars. Is there an example theme which does include this featrue? because i'm trying to incorporate that feature into a wps and whenever i try to load the third progressbar, i get an "Invalid parameter list" error...
here's the code by the way:

Code: [Select]

%Vl|a|0|161|206|23|1|-|-|
%pb|pb.bmp|18|-|206|23|
%Vl|b|0|213|206|23|1|-|-|
%pb|pb1.bmp|18|-|206|23|
%Vl|c|0|182|206|23|1|-|-|
%pb|pb2.bmp|18|-|206|23|

if i delete the last Viewport, everything works fine. I fear that only two pbs are supported...

[MarcGuay]

I think your third viewport is overlapping the first.

161 + 23 = 184

*Conditional*, right.  That shouldn't matter.  Thinking cap back on.

[JdGordon]

it should work... how many other bitmaps are you loading?

[MarcGuay]

Wait a second.  Are you trying to display viewports 'a' and 'c' at the same time?  If so, I think it's logical that you'll get an error due to overlapping viewports.

[Chronon]

I didn't think that overlapping viewports would lead to an error, just that the one defined later in the code would be drawn over the contents of the earlier one.

[BdN3504]

does it matter, how many images i have loaded? But i tried removing all the images and it still doesn't work, so i don't think that is the problem...

here's how i want to display the VPs

Code: [Select]

%Cl|52|44|c136|c136|
%?C<%?mh<%Vda|%C%Vdc>|%?mh<%Vda|%Vdb>>
%Vl|a|0|161|-|23|-|-|-|
%pb|pb.bmp|17|-|206|23|
%Vl|b|0|213|-|23|-|-|-|
%pb|pb.bmp|17|-|206|23|
%Vl|c|0|193|-|23|-|-|-|
%pb|pb.bmp|17|-|206|23|

[MarcGuay]

There is a limit to the total size of the images used, it's mentionned on the CustomWPS wiki page.

I suggest you verify that you have no overlapping viewports.  Maybe it's changed since they became conditional but it would definitely break the WPS before if they did.

Also, would it be possible for you to change your avatar?  It's very obnoxious to the eyes and I'm tempted to ignore your posts because of it.

[Chronon]

I think it has changed.  The CustomWPS page indicates that viewports do not get drawn transparently, but indicates that they can be drawn over each other.  In fact, I modified a theme that was not displaying any text (because it was in the default viewport with other viewports defined) and I fixed the problem by defining a new viewport that fills the entire screen.  The theme already has several non-overlapping viewports and these now get drawn over the viewport that I defined that contains album art and text.

[BdN3504]

It's not working, no matter what i do. Look, even this code (yes that's the entire wps file) does not work:

Code: [Select]

%X|bg.bmp|

%V|0|10|-|23|-|-|-|
%pb|pb.bmp|17|-|206|23|
%V|0|100|-|23|-|-|-|
%pb|pb1.bmp|17|-|206|23|
%V|0|200|-|23|-|-|-|
%pb|pb2.bmp|17|-|206|23|

There aren't even any conditionals in that one and there's no way these viewports overlap. This is not good. somebody may review the changes done to the wpssyntax. Or you anounce that only two playbars can be used per WPS.

Is this a cul-de sac? the only way to get around this would be to create to different themes, right?

[pixelma]

Code: [Select]

%V|0|10|-|23|-|-|-|
%pb|pb.bmp|17|-|206|23|

I'm not entirely sure this is happening here and haven't tried myself yet but: the possibility to leave the y-position unspecified and use the - instead was a concession, made to let the non-bitmapped progressbar work as before. This means that if you leave it "blank" the progressbar should be put in the middle of the line as specified by the line of text in the .wps file, so wouldn't mean "zero".

Now that you specify a progressbar height of 23 there this way in a viewport that is only 23 pixels high itself and probably with a font less tall than 23 pixels, I can imagine two possible problems: (1) what happens with those "line based" progressbars when the height is greater than the font size and (2) if Rockbox tries what I would expect and put the middle of the progressbar on the middle of the first line of text this would mean the progressbar would cross the viewport's border - what happens in general when a progressbar is bigger than the viewport it is supposed to be in?

Hope that makes sense...  and it leads me to the question: have you tried specifying the y-position of the progressbar as 0 ?

[BdN3504]

Code: [Select]

%X|bg.bmp|
%Vl|a|18|10|206|23|-|-|-|
%pb|pb.bmp|0|0|206|23|
%Vl|c|18|100|206|23|-|-|-|
%pb|pb1.bmp|0|0|206|23|
%Vl|c|18|200|206|23|-|-|-|
%pb|pb2.bmp|0|0|206|23|

shit no worky worky! I've tried playing around with all possible variants of the parameters. this one works best, if you only use 2 pbs, but three still is not working!

[knight4led]

I was having trouble with multiple progress bars as well. Though different, I couldn't get a non .bmp progress bar to display at all on a .wps that already had a .bmp progress bar. I suspect something is a little broken in there.

[Llorean]

If you're sure it's a bug, why haven't you filed a bug report?

[BdN3504]

First, i don't know how and where to file a bug report and second i wasn't sure if the commit really introduced support for 3 playbars or just two.

[pixelma]

Did you try 3 progressbars in the default viewport (i.e. not defining any %V at all)?

First, i don't know how and where to file a bug report

See the "bugs" entry in the left hand side of the menu below the "Tracker" headline...