Bookmarking on the E260 and not working with the SD card files

[gigaMojo]

  I've noticed that while bookmarks appear to work on files located in main memory, those on the SD expansion card do not get bookmarked.

 I see some threads saying it does work and has something to do with whether you play from the database or the files screen, but I have not noticed this.

  I'm not sure why this relatively simple process should be buggy at all after all this time.

[Llorean]

If you think it's so simple, feel free to fix it. If you don't have the skill to fix it, it's not simple, and you need to reconsider making such statements.

What do you mean by not having noticed that you can't bookmark in database? Give a process to exactly reproduce the problem you're having, and tell what build you're using.

[gigaMojo]

  No need to get excited.   I believe this is a chronic problem as I see it mentioned elsewhere in the past.   I am a programmer and am well aware of what's involved in maintaining a platform such as this, though I would not be able to assist in this particular case.


  Now , apparently , when playing a file from  expanded storage ( a 2 gig card) and from the DATABASE/ ALBUMS  picklists,  there is no bookmark created on STOP.

  A bookmark is created  when the same mp3 is played from the FILES picklist.

  That's it.

  I'm not sure this is the best board for this thread, would there be a better spot for it?

[Llorean]

Bookmarks do not work with the database. This is not a problem, this is just a fact about how they work. This is stated in several places.

[gigaMojo]

 Prompt response.

 Yeah, apparently thats it.   Must say I'm not too happy about it.

  Is there some reason for this or has it simply not been programmed? Seems like a glaring omission of functionality.

[Llorean]

The bookmark format was designed for efficiency prior to the inclusion of the database feature. The original design cannot work with the database, and while database is popular among the users, among the designers it is not widely used.

Since the developers are volunteers, they work on their own areas of interest. As you've noted yourself, you don't have time to give to the project. Apparently nobody who'd like to resolve the problem has had the time to give to create an adequate solution.

Please stop using language like claiming it's an "omission" or stating something is "relatively simple" when you have no understanding of the factors behind it. The simple statement is this: Rockbox is not a product. It is created by the developers, for the developers. If you want to have a say on what functionality should exist, become a developer. Otherwise, feel free to make suggestions, but don't use language that makes it sound like your picture of the project matters. What matters is their opinion of what needs done. You don't define what it should be, so you don't define what has been "omitted" from the picture.

[gigaMojo]

 Assuming the 'developers' are anything like you, I'm not surprised this bug has not been fixed.

 And you are quite mistaken, no 'product' , free or otherwise , should take a pompous 'take it or leave it' attitude. You are a poor spokesman for so easily taking offense at a BUG report.

 And yes, it's pitiful that bookmarking does not work with the database after all this time , especially considering all the esoteric stuff thats worked on and is used by 1% of the userbase.



 I would be glad to fix it if my programming skill set was in this area but it isn't.   What's the big deal, all you have to do is hook the stop routine and create the bookmark for the current file.  Rocket science?

[Llorean]

First: It's not a bug. A feature that was never implemented cannot be a bug. Otherwise it's a bug that we don't play h.264, or that Rockbox doesn't make toast.

It is take it or leave it. People are working on it because THEY want it. They kindly offer it to you for free. But they don't depend on you, in any way. It's absolutely truthful that it will not harm them in any way if you decide Rockbox does not meet your need and choose not to use it. The preference is that you actually decide to spend some time making it meet your needs, like they do, but you're welcome to decide that just because you can't be bothered to learn what is necessary to contribute, you aren't to blame for your features not being there while the people who do spend hundreds of hours working on the features they want are to blame for not selflessly spending their own time working on a feature they don't care at all about because you said it needs to be done.

What is pitiful is that you think anyone should work for you, for free, doing something they don't want to do, when you yourself are unwilling to put the time and effort into learning to do it yourself.

The bookmark includes all the necessary information to recreate the in-memory playlist. It does this by bookmarking a position in an existing playlist (only available if it comes from an m3u) or within a directory. Database search queries work entirely differently, generating a dynamic playlist from a search. That search could have entirely different results on a reboot of the player and cannot be used. Therefor the entire bookmarking system would need to be rewritten to no longer simply use an index, but instead store an exact listing of all tracks currently being played. So no, its NOT as simple as hooking into the stop routine and creating a bookmark, because there is no system for creating a meaningful bookmark based on playback initiated from the database.

[JdGordon]

While Llorean has said what I wanted to say (the techinal reasons behind the "bug" (which we actually have several proper bug reports on the issue, including at least one in the bug tracker which is that nice left on the left that says "Bugs"), nothing has been done about it because only one or two devs actually know how the database works.

I was intending on going into the database code and understanding it enough to fix this bug, (and this is where you should start kicking yourself...) I'm seriously reconsidering because of your attitude. neither the DB or bookmarks are features I use, but I have spare time and it is a bug which we agree should be fixed... You've just prolonged the wait for yourself...

also, anyone who thinks of themselves as a programmer and still says things like "relatively easy" and "simple fix" ought to either be shot or have the title removed. C is easy and any real programmer can look at it and get to know new code if they really want to..

So, now you have the option of waiting for *as long as it takes* to have it fixed.. or get of you ass and do it yourself

[gigaMojo]

 Is everyone here under 21 or something?  I never saw a more self righteous crew in my life.

  If you don't think it's an embarrassment to have the bookmarks only half working, then don't fix it.

 It's a small thing, but  now I know why you guys work for free, as no one in their right mind would pay you.

[soap]

Locking this as it is going nowhere productive.
May calmer heads prevail.