Support of tags on AC3 files

[Mdkart]

Hello,
I use AC3 to listen to my live dvds on my rockboxed X5. I tag my AC3 songs with foobar. This adds Apev2 tag to ac3 files.

The problem is that rockbox don't read these tags on AC3 files. So I'm trying to make a patch to make rockbox use this tags.
I'm searching in the source files the way to do it for some hours now.
I've tried to add  read_ape_tags(fd, id3); in /apps/metadata.c. So I have this code :

Code: [Select]

case AFMT_A52:
        if (!get_a52_metadata(fd, id3))
        {
            return false;
        }
		
		read_ape_tags(fd, id3);
        break;

But it don't seems to add the support of the tag.

Could someone help me? I would be very happy because ac3 take much less space than flac files for the same quality for audio extracted from dvd.

[Lear]

It worked fine when I tested it in the UI simulator.

[Mdkart]

Do you mean that the tags on ac3 are supported natively or is it the modification above that worked?
Cause I've compiled a sim for my X5 with the modification I've described but this don't add the support of tags neither in the datbase nor in the wps.

[Lear]

The modification worked.

[Mdkart]

Ok that's true, the modification I've described in first post works! I tested this too fast...