screen drawing issues after r17763

[JdGordon]

let me know of any screen drawing issues which you find after this commit... worst case you should find (if there is a problem screen) is that the screen seems shifted up by a few pixels....

[LambdaCalculus]

I'll keep a lookout for any weirdness.

[kugel.]

Regarding commit r17763 (remove LCD margins): Wouldn't it be better to require the themer to use 0,8 if the statusbar is enabled (and he doesn't want to overlap anything), and let the statusbar overlap the stuff in the vp if 0,0 is used respectivly? sounds very confusing and inconsistent to me if 0,0 can be 0,8. Also, what happens if it's 0,1 etc?)

[JdGordon]

it was explained in IRC to you, but for the sake of others ill reply anyway..

0,0 is the top left of the usable viewport... the default viewport uses the whole screen, but when the statusbar is enabled that viewport is dropped by 8 pixels (which happened before the commit also just it was less obvious).

the only people who would even notice there is an issue are those with a WPS that has bitmaps and the statusbar and the bitmaps are 8 pixels lower than they should be...

[Llorean]

Just a note, only the default viewport moves. If you create your own viewport at 0,0, it won't move (and nothing in it should) so you can still quite easily create a WPS where if the status bar is on, it will block the display of text. Why you'd want to is beyond me, but it's still quite possible.

[shotofadds]

From around the time this went in, I'm seeing flickering when entering the WPS (Cabbie v2) and on track changes. The progress bar and battery/hold/pause icons seem to be cleared for a fraction of a second and then re-drawn.

I'm seeing this on my D2, but PaulJam has also seen this on his H300 and reckons it might be because the default WPS has overlapping viewports.

[DancemasterGlenn]

From around the time this went in, I'm seeing flickering when entering the WPS (Cabbie v2) and on track changes. The progress bar and battery/hold/pause icons seem to be cleared for a fraction of a second and then re-drawn.

I'm seeing this on my D2, but PaulJam has also seen this on his H300 and reckons it might be because the default WPS has overlapping viewports.

I too am seeing this lately on my ipod video, and had a feeling it might have something to do with viewports/screen redrawing in general/whatever was changed to stop the cabbie buttons from showing up in the main menu when shutting down.

[JdGordon]

I'm seeing this on my D2, but PaulJam has also seen this on his H300 and reckons it might be because the default WPS has overlapping viewports.

Pauljam is 100% correct, and if it wasnt the default theme I'd ignore it because honestly its not that big a deal... but it is, so ill fix it...