Feature Request: Browsing Themes with Subfolders

[BdN3504]

I would like to suggest the following feature: Some themes come with different backgrounds and colourschemes (e.g. the acotil themes for sansa e200), but the cfg files are all in the same "themes" folder. Now i tried creating a subfolder within the themes folder, to collect themes of the same kind in one place, but when i select browse themes in the menu, the folder doesn't show up. Could anyone try to implement this, because it would make browsing themes easier, and more comfortable. You could then, for example, create a subfolder which only holds themes that use AA. What do you think of this proposition? Has it already been proposed?

[bascule]

You can find out yourself whether or not it has already been proposed, by searching Flyspray for Feature Requests or Patches. It looks like a feature request exists.

Alternatively, you could browse directly to your new themes subfolders from the Files menu or, even quicker, set up a Shortcut to them...

[Job Van Dam]

If you compile your build own build I can tell you the line to edit so Browse Themes will also display folders.

[BdN3504]

This one?

The Shortcuts thing is ok but I started looking around the source code and by referencing the Commits since 4 weeks back I was able to find out where the Themes menu was (apps\menus\theme-menu.c,  Embarrassed) and started messing around with a single line.

I started messing around with this line (currently line 172):
Code:

static struct browse_folder_info themes = {THEME_DIR, SHOW_CFG};


and after a few tries changed it into this:
Code:

static struct browse_folder_info themes = {THEME_DIR, ""};



It does exactly what I wanted it to do now, the Browse Themes menu displays folders. At compilation it displays a small error but it still works though.

Thanks to everyone in this thread for there help, Jonathan Gordon for putting together the Themes menu and all the Rockbox developers for making the code so flexible and easy to read. Grin
« Last Edit: October 15, 2007, 05:54:15 pm by Job Van Dam »

But then again, "" includes every type of file in the browse themes menu, doesn't it? Is there not a possibility to SHOW_CFG and SHOW_DIR only?

[Job Van Dam]

Wow, good stuff BdN. Your not lazy and actually used the search function.

Yes, that's the method I was going to suggest.
Unfortunately, there's is no way, I know of anyway, to have the Browse Themes screen only display cfg's and directories. Chances are you (or someone else) will probably have to write it yourself.

Just curious, what other file types do you store in the themes folder anyway?