Support and General Use > Theming and Appearance Customization

Viewports vs custom line

<< < (2/2)

Llorean:
We have a contribution document explaining coding style. We've never rejected a patch based on style alone, simply explained to the author they need to resolve issues with it.

As for outdated, patches only become outdated when the author doesn't follow through and meet the requirements to get it committed.

Basically, both of these should only happen if whoever writes the patch chooses not to follow through with getting the work actually *done* and instead throws together some demo code, and leaves it in the hope of someone else doing the rest of the work.

If you don't want to do it, you're welcome to say "No thanks" but please don't simply try to claim we'd reject it outright, especially when it's something we actually want to see done.

hakimio:
Llorean, tell me what happened to this patch which was written in 2006-01-09?

Llorean:
The author hasn't pursued getting it included in SVN, as simple as that.

With features, the developer working on the feature will often keep a watchful eye for patches that improve the feature or fix bugs. With plugins such as this, though, most developers are working on their own things so the plugin author will have to come forward and say "I feel my plugin is complete enough for conclusion. Could I get a developer to look over it."

You'll notice it isn't rejected, so I don't see what it has to do with your prior statements anyway. It really bears no relation at all to the feature I propose you work on (a core feature that's highly wanted by both the developer and user community as compared to a plugin that is not actively developed at all, and the author has not followed up on, which is EXACTLY what I said it necessary above).

Navigation

[0] Message Index

[*] Previous page