Support and General Use > Theming and Appearance Customization

Viewports vs custom line

(1/2) > >>

hakimio:
I am wondering why rockbox devs choce to keep Viewports instead of custom line.

Here are few reasons why I think Viewports are WORSE than custom line:
1) Viewports can not be used in conditional tags (i.e. %?C or %?mh);
2) Viewports are drawn on top of the album art (maybe it's a bug?)(...and putting album art tag at the bottom doesn't solve the issue because AA respects viewports, tries to draw AA in the viewport, which was specified above, and fails if the viewport is too small for it).

Do you know any viewports pros? Do you also think choosing viewports instead of custom line was a good decision?

Llorean:
1) Using them with conditional tags is being addressed.
2) Everything is supposed to be inside viewports, album art included. Obviously if you actually plan your viewport to be the right size, and have properly sized album art it being "too big" and being clipped will not be a problem.

Viewports are vastly more flexible. They allow vertical clipping as well as horizontal, and extend as a system to add flexibility to the rest of Rockbox. Unless you're familiar with the technical details of how both are implemented, don't assume that one unfinished system is inferior to a hack that was in common use in unsupported builds. Scrolling lines really cannot offer the expandability that viewports can.

Also, I've removed your link to an unsupported build and themes not posted in the official gallery. Please, follow the forum guidelines. Also remember that abbreviations such as "imho" should be avoided in favour of real words for our blind and non-native speakers.

hakimio:

--- Quote from: Llorean on May 17, 2008, 01:20:34 PM ---1) Using them with conditional tags is being addressed.
--- End quote ---
Hope this will be implemented soon...


--- Quote ---Also, I've removed your link to an unsupported build and themes not posted in the official gallery. Please, follow the forum guidelines. Also remember that abbreviations such as "imho" should be avoided in favour of real words for our blind and non-native speakers.

--- End quote ---
It seems you have very strict rules here...

Llorean:
1) This will be implemented just as soon as a volunteer implements it. Remember that all work is done by volunteers. You're welcome to pitch in.

As for the rules, if you'd read them as you agreed to when registering you would've known what they were. I suggest you go ahead and do that now. They're posted in the announcements forum.

hakimio:

--- Quote from: Llorean on May 17, 2008, 01:47:28 PM ---You're welcome to pitch in.
--- End quote ---
The patch would be rejected because of coding style or after a year or so it would be rejected because it would be outdated. So why bother?

PS: I do understand that the project is lead by volunteers.

Navigation

[0] Message Index

[#] Next page