Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Recording
| | |-+  trigger screen update complaints/issues thread
« previous next »
  • Print
Pages: [1]

Author Topic: trigger screen update complaints/issues thread  (Read 3966 times)

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
trigger screen update complaints/issues thread
« on: May 13, 2008, 11:18:01 AM »
reply with any issues/comments/complaints that havnt been mentioned yet...
« Last Edit: May 28, 2008, 06:58:19 AM by jdgordon »
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Davide-NYC

  • Member
  • *
  • Posts: 429
Re: updated trigger settings screen.. test + comment before it goes in...
« Reply #1 on: May 16, 2008, 10:11:50 PM »
OK I just installed the patched build provided on an H120.

Problems:

  • The setting do not take effect immediately. One has to highlight an adjacent line (up or down) before the setting takes effect.
  • The two-line-per-parameter display is confusing. Putting the Label on the Left and the Value on the right of a single line should be clearer. It also allows everything to be on the H120 screen at once without sdcrolling.
  • The left icon (Stop square) does not change in the trigger screen. (it works in the WRS)


That's what I found so far. I'll test again once a new version of the patch is provided. Please provide the build zip. I was unable to patch cleanly. Must be some parameter of "patch" that I'm not familiar with.

Thanks for this!
Logged
Currently: iRiver H132-RTC-CFMod

Offline LambdaCalculus

  • Member
  • *
  • Posts: 2257
  • Dreaming of Turing Machines...
    • The Nostalgia Roadtrip
Re: updated trigger settings screen.. test + comment before it goes in...
« Reply #2 on: May 17, 2008, 07:57:55 AM »
Did you use the -p0 parameter to apply it? Like so:

Code: [Select]
patch -p0 < patchfile

This should allow it to apply clean.
Logged
Former Rockbox dev. Rising from the ashes...

Players: iPod Video /w 128GB SSD mod, H320 /w 128GB SSD mod

Offline Davide-NYC

  • Member
  • *
  • Posts: 429
Re: updated trigger settings screen.. test + comment before it goes in...
« Reply #3 on: May 19, 2008, 11:35:17 AM »
I tried multiple "p" levels and couldn't get it to apply without having to input every file path. I was too lazy to do so since the zip was available. ;-)
Logged
Currently: iRiver H132-RTC-CFMod

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: updated trigger settings screen.. test + comment before it goes in...
« Reply #4 on: May 21, 2008, 10:08:52 AM »
new version is on the tracker... try it out.. or just put up bug reports after its in svn...
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Davide-NYC

  • Member
  • *
  • Posts: 429
Re: updated trigger settings screen.. test + comment before it goes in...
« Reply #5 on: May 22, 2008, 01:49:34 AM »
Oh no, bad news...   :o

I got all sorts of wierd disk errors. At first I thought it was either a bad CF card or a bad battery on one of my H120s (CFMod+RTC) but then it happened to my other H120 as well (same mods though).

Something definitely is amiss.  ???


Nonsense. I must remember to change my boot preferences when I test patches!!!!  >:(

All seems ok with the patch (from a preliminary test) aside from lack of remote keymaps and that the stop icon does not redraw properly in the trigger screen as previously reported. Cool beans!
« Last Edit: May 22, 2008, 02:09:52 AM by Davide-NYC »
Logged
Currently: iRiver H132-RTC-CFMod

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: updated trigger settings screen.. test + comment before it goes in...
« Reply #6 on: May 27, 2008, 08:14:39 AM »
Can you test out the latest version on the tracker?
I've "added" the remote keymap (as in, buttons probably need fixing)... in my quick testing it definatly looks like the stop icon isnt updating... can you let me know if the triggering does actually work though? I'm completly baffled as to why its not changing correctly
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Davide-NYC

  • Member
  • *
  • Posts: 429
Re: updated trigger settings screen.. test + comment before it goes in...
« Reply #7 on: May 28, 2008, 12:40:29 AM »
Quote
Can you test out the latest version on the tracker?

I used the rectrigger.3.diff version which is the latest on there currently.

Quote
can you let me know if the triggering does actually work though?

I made some test recordings and they worked correctly.
Logged
Currently: iRiver H132-RTC-CFMod

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: updated trigger settings screen.. test + comment before it goes in...
« Reply #8 on: May 28, 2008, 06:57:33 AM »
ok, this has just been commited.... complaints/comments/issues from this post down thanks....
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Recording
| | |-+  trigger screen update complaints/issues thread
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.076 seconds with 14 queries.