Support and General Use > Recording

Histogram

(1/4) > >>

zenx:
Hi!

I've been using an old build on my h120 with the "Recording enhancements pack" up until lately. It had the nice histogram patch included. I miss this feature. Can someone please sync the patch to a current build?

Howcome this is not included in the daily builds already?

Thanks,
Z

AlexP:

--- Quote from: zenx on May 09, 2008, 02:41:38 PM ---I've been using an old build on my h120 with the "Recording enhancements pack" up until lately. It had the nice histogram patch included. I miss this feature. Can someone please sync the patch to a current build?

--- End quote ---

I suspect that the REP is so out of date by now that this will be a large amount of work.


--- Quote from: zenx on May 09, 2008, 02:41:38 PM ---Howcome this is not included in the daily builds already?

--- End quote ---

It could be a large number of reasons:

1)  Is it wanted, or are the drawbacks of adding it bigger than the advantages?
2)  Is it written correctly, or is it just hacked on?
3)  Does it work on all targets with recording?
4)  Does it conform to Rockbox coding guidelines?
5)  Is it remotely up-to-date?  A developer with commit rights would need to add it, and just reviewing this patch to make sure it doesn't break anything else would be a very large amount of work, without bringing it up to date first.
6)  It seems to add quite a few different features.  Patches should be for one feature only - it makes them much easier to review and check, and to fix if there is a problem.
7)  There may well be many other reasons.

Someone who wants these features needs to go through and check these and make any changes required.

petur:
I've been planning to try to update the histogram patch, but holding off because of the pending conversion of the recording screen to viewports

I'll have a look how bad it is...

b0br:
Please, do that, I would really apreciate it!
Histogram is the only reason I still use half an year old build..

Topy:
Sorry to bring up this old topic, but:
I too am really interested in getting back the histogram.

Just for fun i just applied it to an old revision and built it, and it really is great. I used to use an ancient version on my X5L for ages because it was the last version i could get the histogram patched in. Then my X5L broke and i was without a Rockbox able player/recorder for a while, and now finally i have a new device (H340) and would really like to get this feature back, its one thing that makes a rockbox device an even better recorder then most purpose made spezialized devices...

I just tried doing it myself, but so much has changed since, mostly in the UI, that i cant get it to work. Please please, get the patch updated or even commited... Or add the functionality from scratch if the old code is completely outdated.

Navigation

[0] Message Index

[#] Next page