Support and General Use > Theming and Appearance Customization

Maximum number of viewports?

(1/2) > >>

wintermute23:
I have a WPS which worked fine, and then I added an innocuous extra bit of information to it, and it hung whenever I went to play music; it didn't even give me the default WPS, just froze up saying "Loading".

A little investigation discovered that it was because I had increased the number of viewports (not including the implicit, fullscreen VP) from 15 to 16. Am I right in thinking that this is a hard limit? Does it vary between targets? Is this a bug to be fixed, or a feature that will remain for the forseeable future?

I think the Wiki page on building custom WPS's ought to include this datum, but (as a newcomer here (though not to RockBox)) I don't plan to change it without knowing other people's opinions. I have no idea what discussions on this topic I've missed.

gevaerts:
I'm not a viewport specialist, but the code contain the line

--- Code: ---#define WPS_MAX_VIEWPORTS   16
--- End code ---
so I think you are correct. This limit is the same for all players with a bitmap screen.

hhannah:
Additionally, by experience, I'd say that the limit would "normally" be enough to make WPS's work; it would take a quite complicated WPS to need more viewports; what I'm saying is, if you feel you need an extra viewport, you could probably "eliminate" an unnecessary viewport definition, to have a free viewport under the limit.

wintermute23:
That is indeed what I discovered. I've successfully eliminated three, and there are a couple of others that can go, too.

I'd just managed to get myself into a 1 datum per viewport mindset, which is convenient enough, so long as you don't have too much data on the WPS.

BdN3504:
Sorry for hijacking this thread but the title fits my concerns...
In the commit changing the wps syntax etc. the maximum number of VPs has been increased to 24. In the original discussion thread to this commit, it has been suggested that this number could easily be raised to 32. I'm recently working on a WPS that uses conditional viewports and have now come to the conclusion that 24 VPs is too little, 32 would be perfect. Could we still change this without breaking everything else in the recent build?

Navigation

[0] Message Index

[#] Next page