Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Rockbox General
| |-+  Rockbox General Discussion
| | |-+  battery_bench patch not applied and closed. ???
« previous next »
  • Print
Pages: [1]

Author Topic: battery_bench patch not applied and closed. ???  (Read 1544 times)

Offline AstroBoy

  • Member
  • *
  • Posts: 52
battery_bench patch not applied and closed. ???
« on: April 23, 2008, 09:03:49 PM »
I don't understand why this was closed.  Can someone explain it?
http://www.rockbox.org/tracker/task/6860
http://www.rockbox.org/tracker/task/8070

I need this applied to run the battery_bench.  Otherwise most of the stats are lost.
example:
-Skipped 2546 measurements from 00:00:16 to 12:51:51-
.
.
.
16:59:21,  61161,     000%,     00:00,           3282,     3545,  -,  -
16:59:26,  61166,     000%,     35791393:58,           3280,     3546,  -,  -

The first 13 hours are lost, 4 hours are reported.
Oh, it looks like the time remaining went negative.  :)

I don't think the sansa e250 is reporting correct battery life within RB.
From what I understand, someone can use the output from battery_bench to correct the battery life calculations.

Thanks.
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: battery_bench patch not applied and closed. ???
« Reply #1 on: April 23, 2008, 09:11:07 PM »
#6860's values were all collected from a version of Rockbox that would make them completely wrong for the current version.
#8070 isn't closed.

Which one are you asking about?
Logged

Offline AstroBoy

  • Member
  • *
  • Posts: 52
Re: battery_bench patch not applied and closed. ???
« Reply #2 on: April 23, 2008, 09:15:54 PM »
I guess I was talking about 6860.

Are you saying the current build does not lose most of the data?
If so, I will run another test.

Thanks.
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: battery_bench patch not applied and closed. ???
« Reply #3 on: April 23, 2008, 09:19:38 PM »
I'm saying that patch #6860 has nothing to do with losing data. It was an attempt to make the estimates right, but was based on the codebase before many of the power drain concerns were improved, so it's drastically wrong now.
Logged

Offline AstroBoy

  • Member
  • *
  • Posts: 52
Re: battery_bench patch not applied and closed. ???
« Reply #4 on: April 23, 2008, 09:26:55 PM »
Ok, I understand.  I thought it would be wrong to close the case if it has not been fixed.  But now I understand, 6860 is not a bug report, but a patch request.  The bug still exists, but the patch has been rejected.

Thanks.
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 8974
Re: battery_bench patch not applied and closed. ???
« Reply #5 on: April 23, 2008, 11:59:13 PM »
Quote from: AstroBoy on April 23, 2008, 09:26:55 PM
Ok, I understand.  I thought it would be wrong to close the case if it has not been fixed.  But now I understand, 6860 is not a bug report, but a patch request.  The bug still exists, but the patch has been rejected.

Thanks.

6860 is calibration for the e200's battery.  I committed a different patch to do that ages ago, thus this patch has been rejected. 

Edit:  Or maybe Buschel did it.  I can't remember.
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox General
| |-+  Rockbox General Discussion
| | |-+  battery_bench patch not applied and closed. ???
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.071 seconds with 15 queries.