Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Installation / Removal
| |-+  Manual Installation
| | |-+  Apple - Installation/Removal
| | | |-+  iPod first generation install?
« previous next »
  • Print
Pages: 1 ... 4 5 [6]

Author Topic: iPod first generation install?  (Read 46241 times)

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: iPod first generation install?
« Reply #75 on: March 21, 2008, 04:28:03 PM »
I assume the reason there was a check there in the first place is that there is a downside to applying it indiscriminately, and therefore we want a reliable way of checking between first and second gen iPods.  
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: iPod first generation install?
« Reply #76 on: March 21, 2008, 04:28:21 PM »
Just as we previously hadn't known there were 1Gs that didn't report their version the way we expected, what is the effect this will have if their are 2Gs with a similar problem or quirk?

So, "why not" is "we might be fixing the bug by simply shoving it off on other users we don't know about yet."

As for the "unsupported" nature of this build, we've truthfully had bug reports filed where the patch "should not" have affected the area the report was on, but did. It would be best if you tried to give it a week or two for an official fix for this problem, then verify any bugs you find in it, because the build environment can really cause some interesting quirks in builds, and patches (especially on portalplayer) can have some very interesting side effects at times, but if you come across something you feel absolutely confident is something we wrote, rather than something misbehaving unexpectedly, speaking up now may be best.
Logged

Offline bidmead

  • Member
  • *
  • Posts: 26
Re: iPod first generation install?
« Reply #77 on: March 21, 2008, 04:41:29 PM »
@BigBambi But this check (as described) isn't indiscriminate.  It's not a kluge.  AIUI it specifically doesn't apply the scrollwheel handling to 2G.   If there are 2Gs reporting as 1G I can see there would be a problem.  Similarly if there are 1Gs that need the scrollwheel handling but report as 2G.  Or even if there's a logic bug in the RB generation reporting.  This patch will expose those anomalies, and so be A Good Thing(tm).

@Llorean  I take your point about knock-on effects, and certainly won't be jumping the gun with a shower of bug reports, for that and other reasons.  

--
Chris
Logged

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: iPod first generation install?
« Reply #78 on: March 21, 2008, 04:47:04 PM »
Quote from: bidmead on March 21, 2008, 04:41:29 PM
@BigBambi But this check (as described) isn't indiscriminate.  It's not a kluge.  AIUI it specifically doesn't apply the scrollwheel handling to 2G.   If there are 2Gs reporting as 1G I can see there would be a problem.  Similarly if there are 1Gs that need the scrollwheel handling but report as 2G.  Or even if there's a logic bug in the RB generation reporting.  This patch will expose those anomalies, and so be A Good Thing(tm).
--
Chris


Right, but the point is that it is now applied to everything that doesn't report as a 2G (within a 1G2G ifdef) rather than everything that reports as a 1G, so if there are 2Gs that don't report as such (not just reporting as a 1G), or if we want to extend the code in the future to other similar players it could cause a problem.  I agree that it isn't a completely horrendous hack (i.e. just enabling for everything), but a way of properly detecting 1Gs would be preferred, and that is what I believe the devs are searching for.
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline yapper

  • Rockbox Expert
  • Member
  • *
  • Posts: 794
Re: iPod first generation install?
« Reply #79 on: March 21, 2008, 04:49:25 PM »
Quote from: Llorean on March 21, 2008, 04:28:21 PM
Just as we previously hadn't known there were 1Gs that didn't report their version the way we expected, what is the effect this will have if their are 2Gs with a similar problem or quirk?

I actually did some testing on a 2G, with a version of the patch that was set to trigger scroll wheel enable on anything that didn't return a version of '7', and there are no noticeable side effects. I believe one of amiconn's early versions of powersaving for the 1G2G also sent the powersave regardless of 1G or 2G (and he noted it was 'safe' as the GPIO output port used as the enable on the 1G is used as an input on the 2G for headphone detection).
Logged
G2 iPod 20GB / Sansa c240 v1 + 2GB microSD / Sansa c250 v1 / Sansa e250 v1 + 8GB microSDHC / Sansa Fuze v2 + 32GB microSDHC

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: iPod first generation install?
« Reply #80 on: March 21, 2008, 04:57:40 PM »
I'm not saying this is a bad way of doing it (I don't have enough knowledge for that), I'm just explaining why the devs may be searching for a more specific check.
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline yapper

  • Rockbox Expert
  • Member
  • *
  • Posts: 794
Re: iPod first generation install?
« Reply #81 on: March 21, 2008, 05:20:47 PM »
Oh, I agree :-)  I was just providing some additional info. I'm happy to wait for a properly engineered solution.
Logged
G2 iPod 20GB / Sansa c240 v1 + 2GB microSD / Sansa c250 v1 / Sansa e250 v1 + 8GB microSDHC / Sansa Fuze v2 + 32GB microSDHC

Offline Dindojul

  • Member
  • *
  • Posts: 7
Re: iPod first generation install?
« Reply #82 on: March 22, 2008, 07:19:02 PM »
The scrollwheel now works pretty fine :-)
With the AABold theme I don't see any album art... I tried with big color picture as well as with 64x64 4 colors picture.
Thanx a lot for this version!
Logged

Offline yapper

  • Rockbox Expert
  • Member
  • *
  • Posts: 794
Re: iPod first generation install?
« Reply #83 on: March 23, 2008, 04:09:04 PM »
album art needs to be bmp not jpg .... see the wiki for details:
http://www.rockbox.org/twiki/bin/view/Main/AlbumArt

or search this forum area:
http://forums.rockbox.org/index.php?board=24.0
Logged
G2 iPod 20GB / Sansa c240 v1 + 2GB microSD / Sansa c250 v1 / Sansa e250 v1 + 8GB microSDHC / Sansa Fuze v2 + 32GB microSDHC

  • Print
Pages: 1 ... 4 5 [6]
« previous next »
+  Rockbox Technical Forums
|-+  Installation / Removal
| |-+  Manual Installation
| | |-+  Apple - Installation/Removal
| | | |-+  iPod first generation install?
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.171 seconds with 21 queries.