Rockbox General > Rockbox General Discussion

Remember Sleep-Timer on boot

<< < (3/6) > >>

DanRock:
Would what you suggest require a user to manually create the fixed.cfg and not have a menu option?

Llorean:
Yes. This is the current case with fixed.cfg, anyway.

LinusN:
I think Rockbox should always remember the last Sleep Timer value instead of having to edit fixed.cfg.

Llorean:
I don't know. If you set the sleep timer for 15 minutes, and it goes to sleep, next time on do you want to have to remember to unset it before you can play normally? It seems, at the very least, there should need to be one extra step to make it "permanent". This could be saving a fixed.cfg file, or it could simply be an option in the menu "Persistent Sleep".

My suggestion, though, was for the solution I thought might be easiest to code as a once-off for someone to use for themselves. If included, I think the option is more useful.

fml2:

--- Quote from: Llorean on February 20, 2008, 02:33:51 AM ---It seems, at the very least, there should need to be one extra step to make it "permanent".
--- End quote ---
This is an issue that, in general, applies to each and every setting. I.e. should the changes to a setting made manually after boot be persisted on shut down? I.e. each setting could have a 'shadow' flag that would tell if the changes should be persisted.

This is of course an overkill. The general approach now is that almost all changes are persisted. But there are also exceptions. E.g. pitch. I've created a patch (FS#8521) to make it '50%' persistent (read the description in the FS to see what I mean by '50%').

So the question is: what setting category (persisted/non persisted) should the sleep timer belong to?

Navigation

[0] Message Index

[#] Next page

[*] Previous page