Another question re: patches

[baobab68]

Is there a way to find out why in particular a given patch does or doesn't get accepted into SVN?

I am interested in

http://www.rockbox.org/tracker/task/8400
http://www.rockbox.org/tracker/task/5555

A lot of unsupported builds seem to include those (and I love them both on my H320) but I wondered why they never made their way into official builds.

Is it because they can't work on targets that don't have enough buttons?

[AlexP]

It could be:

No interested developer has seen them
They do not work for all suitable targets
They are not written correctly
They take the wrong approach to the problem
They are waiting for another patch to go in first
They are not wanted in rockbox

[baobab68]

Thanks for the prompt answer, I was just curious as to how inclusion or exclusion works.

[AlexP]

Quite often the problem is attracting the attention of a developer with commit access.  Before a patch can go in it must be checked that it works for all targets, that it doesn't break anything else, that it adheres to the rockbox coding guidelines, etc. etc.

This can take some time, and seeing as all our developers are volunteers it is often not to appetising to spend your spare time checking out a patch for a feature you personally don't care about.

[baobab68]

Fair enough.