Support and General Use > Audio Playback, Database and Playlists

Can't play mp3s through 'Files' option (Sansa c200)

<< < (6/8) > >>

cdurst:
Could you try "downgrading" to r16099-20080118 and see if the bookmarking starts working again?

If so, perhaps this bug is the same one as reported in FS#8511(http://www.rockbox.org/tracker/task/8511).

krisdb:

--- Quote from: cdurst on January 31, 2008, 06:12:52 PM ---Could you try "downgrading" to r16099-20080118 and see if the bookmarking starts working again?

If so, perhaps this bug is the same one as reported in FS#8511(http://www.rockbox.org/tracker/task/8511).


--- End quote ---

Downgrading didn't work, but that bug looks a different than the one I'm experiencing.

pokeme444:
tendinitis, can't tyupe much but
bug is killing me! some audiobooks affected, others not!
can't dig code, BUT

diff shows this function changed from

/trunk/apps/tree.c
/*    
     * removes the extension of filename (if it doesn't start with a .)    
     * puts the result in buffer    
     */    
    static char * strip_extension(char * filename, char * buffer)    
    {    
        int dotpos;    
        char * dot=strrchr(filename, '.');    
        if(dot!=0 && filename[0]!='.')    
        {    
            dotpos = dot-filename;    
            strncpy(buffer, filename, dotpos);    
            buffer[dotpos]='\0';    
            return(buffer);    
        }    
        else    
            return(filename);    
    }

to

trunk/apps/misc.c
 /*
1125           * removes the extension of filename (if it doesn't start with a .)
1126           * puts the result in buffer
1127           */
1128          char *strip_extension(const char *filename, char *buffer)
1129          {
1130              int dotpos;
1131              char *dot = strrchr(filename, '.');
1132              if (dot != 0 && filename[0] != '.')
1133              {
1134                  dotpos = dot - filename;
1135                  strncpy(buffer, filename, dotpos);
1136                  buffer[dotpos] = '\0';
1137              }
1138              else
1139                  strcpy(buffer, filename);
1140              return buffer;
1141          }



it seems a likely culprit for a subtle bug like this, especially with this code in the albumart;

http://svn.rockbox.org/viewvc.cgi/trunk/apps/recorder/albumart.c?r1=16102&r2=16103

someone could revert those changes and test whose hands work?

GodEater:
I'd be pretty surprised if that's the problem - the code wasn't changed much (only two lines, and they're trivial), and was moved from one source file to another.

Lear:

--- Quote from: GodEater on February 05, 2008, 02:35:56 AM ---I'd be pretty surprised if that's the problem - the code wasn't changed much (only two lines, and they're trivial), and was moved from one source file to another.

--- End quote ---

Actually, that change can cause problems, though it isn't very likely to. With a file where the full path is more than 250 bytes (exact size depends on album art size), then the strip_extension call in albumart.c can cause a buffer overflow...

I intend to fix that, but I haven't gotten around to it yet. :)

Navigation

[0] Message Index

[#] Next page

[*] Previous page