HELP - updated rockbox and my theme broke (iRiver iHP140)

[Cuppa]

Firstly, first post - Hi and Merry Christmas.  I've just read the 'posting in this forum' notice and not sure if my post will break the rules, if it does I'm sorry, please let me know where to post this or how to ask.  I think the screen is 160 wide, but can't remember how high, etc.

I need help if anyone will be so kind and bugfix my WPS and rWPS for my iRiver h140.  October 2006 I got into WPS creation to get my iriver H140 set up how I wanted it.  After a few days examining other WPSs I cobbled enough knowledge together to knock up something how I wanted it.  A few days of tweaking and I got everything perfect for me and haven't touched it since (nor upgraded rockbox since either).  Was a big effort for me as I'm not that computer literate and kept getting it wrong.

Today, I uploaded a load of new tracks and thought I'd upload a new version of rockbox (14 months later).  Might as well have any bugfixes I thought.  My previous version was a daily build without patches from October 2006 I think.

Well, my nice themes don't work anymore and I can't remember how to code them either.  

I've done a little reading today and it suggests something with stricter controls on supported builds?  As I don't remember a thing about it now, would anyone be able to suggest what in the below would need to be changed?

Thanks in advance, I know I must sound like a muppet, but that's how I feel.  

WPS:

%x|a|background.bmp|0|0|
%xl|b|codec_mp1.bmp|132|48|
%xl|c|codec_mp2.bmp|132|48|
%xl|d|codec_mp3.bmp|132|48|
%xl|e|codec_wav.bmp|132|48|
%xl|f|codec_ogg.bmp|132|48|
%xl|g|codec_flac.bmp|132|48|
%xl|h|codec_mpc.bmp|132|48|
%xl|i|codec_a52.bmp|132|48|
%xl|j|codec_wpk.bmp|132|48|
%xl|k|codec_unknown.bmp|132|48|
%xl|l|codec_vbr.bmp|147|48|
%xl|m|codec_cbr.bmp|147|48|
%xl|n|rpt_all.bmp|60|1|
%xl|o|rpt_one.bmp|60|1|
%xl|p|rpt_shf.bmp|60|1|
%xl|q|mode_stop.bmp|2|48|
%xl|r|mode_play.bmp|2|48|
%xl|s|mode_pause.bmp|2|48|
%xl|t|mode_ffwd.bmp|2|48|
%xl|u|mode_rew.bmp|2|48|
%xl|v|shuffle.bmp|43|1|
%xl|w|lock_main.bmp|97|0|
%xl|x|lock_remote.bmp|108|0|
%xl|y|vol_0.bmp|0|0|
%xl|z|vol_1.bmp|0|0|
%xl|A|vol_2.bmp|0|0|
%xl|B|vol_3.bmp|0|0|
%xl|C|vol_4.bmp|0|0|
%xl|D|vol_5.bmp|0|0|
%xl|E|vol_6.bmp|0|0|
%xl|F|vol_7.bmp|0|0|
%xl|G|vol_8.bmp|0|0|
%xl|H|vol_9.bmp|0|0|
%xl|I|batt_0.bmp|143|0|
%xl|J|batt_1.bmp|143|0|
%xl|K|batt_2.bmp|143|0|
%xl|L|batt_3.bmp|143|0|
%xl|M|batt_4.bmp|143|0|
%xl|N|charge.bmp|143|0|
%wd


%s%ac %?it<%it|%fn>
%s%ac %?ia<%ia|%d2>

%al %t0.8%?mp<%pc%ac%pp/%pe|%pc%ac%pp/%pe|%pc%ac%pp/%pe|%pc%ac%pp/%pe|%pc%ac%pp/%pe>%ar%fb  %?fc<%xdb|%xdc|%xdd|%xde|%xdf|%xdg|%xdh|%xdi|%xdj|%xdk>%?fv<%xdl|%xdm>;%al %t0.2%?mp<%pc%ac%pp/%pe|%pc%ac%pp/%pe|%ac%pp/%pe|%ac%pp/%pe|%ac%pp/%pe>%ar%fb  %?fc<%xdb|%xdc|%xdd|%xde|%xdf|%xdg|%xdh|%xdi|%xdj|%xdk>%?fv<%xdl|%xdm>
%pb|6|29|130
%s%ac%t2Coming up next...;%ac%t3%?It< %It | %Fn >;%ac%t1by;%ac%t3%?Ia< %Ia | %D2 >


%s%al %?id<%id|%d1>
%al    %?ia<%ia|%d2>
%al %?ig<%ig|Unknown Genre>
%al       %?iy<%iy|Unknown Year>


%?pv<%xdy|%xdz|%xdA|%xdB|%xdC|%xdD|%xdE|%xdF|%xdG|%xdH>
%?bp<%xdN|%ac%t0.25%?bl<%xdI|%xdJ|%xdK|%xdL|%xdM>;%ac%t0.25%?bl<|%xdJ|%xdK|%xdL|%xdM>;%ac%t0.25%?bl<%xdI||%xdK|%xdL|%xdM>;%ac%t0.25%?bl<||%xdK|%xdL|%xdM>>
%?mm<|%xdn|%xdo|%xdp>
%ac%t0.8%?mp<%xdq|%xdr|%xds|%xdt|%xdu>;%ac%t0.2%?mp<%xdq|%xdr|||>
%?ps<%xdv|>
%?mh<%xdw|>
%?mr<%xdx|>

RWPS

%x|a|background_r.bmp|0|0|
%xl|b|codec_mp1.bmp|100|48|
%xl|c|codec_mp2.bmp|100|48|
%xl|d|codec_mp3.bmp|100|48|
%xl|e|codec_wav.bmp|100|48|
%xl|f|codec_ogg.bmp|100|48|
%xl|g|codec_flac.bmp|100|48|
%xl|h|codec_mpc.bmp|100|48|
%xl|i|codec_a52.bmp|100|48|
%xl|j|codec_wpk.bmp|100|48|
%xl|k|codec_unknown.bmp|100|48|
%xl|l|codec_vbr.bmp|115|48|
%xl|m|codec_cbr.bmp|115|48|
%xl|n|rpt_all.bmp|41|1|
%xl|o|rpt_one.bmp|41|1|
%xl|p|rpt_shf.bmp|41|1|
%xl|q|mode_stop.bmp|2|48|
%xl|r|mode_play.bmp|2|48|
%xl|s|mode_pause.bmp|2|48|
%xl|t|mode_ffwd.bmp|2|48|
%xl|u|mode_rew.bmp|2|48|
%xl|v|shuffle.bmp|43|1|
%xl|w|lock_main.bmp|91|0|
%xl|x|lock_remote.bmp|101|0|
%xl|y|vol_0_r.bmp|0|0|
%xl|z|vol_1_r.bmp|0|0|
%xl|A|vol_2_r.bmp|0|0|
%xl|B|vol_3_r.bmp|0|0|
%xl|C|vol_4_r.bmp|0|0|
%xl|D|vol_5_r.bmp|0|0|
%xl|E|vol_6_r.bmp|0|0|
%xl|F|vol_7_r.bmp|0|0|
%xl|G|vol_8_r.bmp|0|0|
%xl|H|vol_9_r.bmp|0|0|
%xl|I|batt_0.bmp|111|0|
%xl|J|batt_1.bmp|111|0|
%xl|K|batt_2.bmp|111|0|
%xl|L|batt_3.bmp|111|0|
%xl|M|batt_4.bmp|111|0|
%xl|N|charge.bmp|111|0|
%wd


%s%ac %?it<%it|%fn>
%s%ac %?ia<%ia|%d2>

%al %t0.8%?mp<%pc%ac%pp/%pe|%pc%ac%pp/%pe|%pc%ac%pp/%pe|%pc%ac%pp/%pe|%pc%ac%pp/%pe>%ar%fb  %?fc<%xdb|%xdc|%xdd|%xde|%xdf|%xdg|%xdh|%xdi|%xdj|%xdk>%?fv<%xdl|%xdm>;%al %t0.2%?mp<%pc%ac%pp/%pe|%pc%ac%pp/%pe|%ac%pp/%pe|%ac%pp/%pe|%ac%pp/%pe>%ar%fb  %?fc<%xdb|%xdc|%xdd|%xde|%xdf|%xdg|%xdh|%xdi|%xdj|%xdk>%?fv<%xdl|%xdm>
%pb|6|29|98
%s%ac%t2Coming up next...;%ac%t3%?It< %It | %Fn >;%ac%t1by;%ac%t3%?Ia< %Ia | %D2 >
%?pv<%xdy|%xdz|%xdA|%xdB|%xdC|%xdD|%xdE|%xdF|%xdG|%xdH>
%?bp<%xdN|%ac%t0.25%?bl<%xdI|%xdJ|%xdK|%xdL|%xdM>;%ac%t0.25%?bl<|%xdJ|%xdK|%xdL|%xdM>;%ac%t0.25%?bl<%xdI||%xdK|%xdL|%xdM>;%ac%t0.25%?bl<||%xdK|%xdL|%xdM>>
%?mm<|%xdn|%xdo|%xdp>
%ac%t0.8%?mp<%xdq|%xdr|%xds|%xdt|%xdu>;%ac%t0.2%?mp<%xdq|%xdr|||>
%?ps<%xdv|>
%?mh<%xdw|>
%?mr<%xdx|>

[MarcGuay]

I'd guess that there's a problem with your progress bar declarations in both the regular and remote code:

%pb|6|29|130

Check the wiki for how these are supposed to be and throw another pipe (|) at the end to be sure.

[Cuppa]

Thanks for replying, I'll go take a look.

EDIT -  Hmm, didn't work.  I seem to remember I butchered one of the engineer WPSs to start mine off, so I'll go look at the updated ones and see if there are any tips.  I wonder if there are a) any image changes I need to be aware of as the original never worked until I changed the background image or b) a place where I can download an old version of the rockbox build circa November 2006.

[Cuppa]

After delving around in the forums, I suspect my error is the same as here...

http://forums.rockbox.org/index.php?topic=13304.0

I just don't understand enough about it to debug it.  Do I have any of these unclosed conditionals in my code?

[MarcGuay]

%x|a|background.bmp|0|0|

Okay, seriously, I'm way too nice.  The X in this line needs to be capitalized and you can do away with the 0's at the end so it looks like this:

%X|background.bmp|

%?bp<%xdN|%ac%t0.25%?bl<%xdI|%xdJ|%xdK|%xdL|%xdM>;%ac%t0.25%?bl<|%xdJ|%xdK|%xdL|%xdM>;%ac%t0.25%?bl<%xdI||%xdK|%xdL|%xdM>;%ac%t0.25%?bl<||%xdK|%xdL|%xdM>>

and if that doesn't do the trick, check out the above line.

[Cuppa]

Okay, seriously, I'm way too nice.

Tis appreciated though, thanks for the tips, I'll go have a play.  It's very slowly coming back to me, but with the gap 'away' I don't really know what's changed.

Re the really long line you quoted also, I seem to remember that that gave me a nice flashing icon for FF/REW and Pause, but not stop or play icons.  It's been a while though so I may be wrong on that one.

[Cuppa]

Still no joy, how do I get the debug tools working?  I have downloaded UISimulator and have run it with the --debugwps switch, but don't see any output anywhere.  Also, don't know where to look for this checkwps in the 'tools' directory - where are these exactly?

[MarcGuay]

Try "commenting out" (aka put a # symbol before it so the system doesn't try to run it) the line I mentionned a few posts above.  That's where the problem seems to lie.  And what that line does, for the record, is display a charging-related image if the player is plugged-in, and if not it displays the battery level.


EDIT:  Try replacing it with this:

%?bp<%xdN|%?bl<%xdI|%xdJ|%xdK|%xdL|%xdM>>

(is it plugged in?
yes : display the image N
no: display the battery level image)

I have no idea what it was doing before with the alternating lines for the battery level but anyway...

[Cuppa]

RESULT  it is that line, thanks man.  Now I just need to get a battery symbol working again somehow, but it's tracked down the problem anyway, thanks again.

[MarcGuay]

No problem.  Did you try the line I suggested it be replaced with?

[Cuppa]

Didn't work, but I've just replaced with a copy from an engineer WPS and all working 100% now.  Looks like there was some changes to the battery power stuff and one extra pipe on the end of the progress bar to sort it.

THANKS AGAIN!

 

[MarcGuay]

Nice, glad to help.  Would you mind posting the line that works, just to sate my curiousity?

[Cuppa]

Sure, here goes.

%t0.2%?bp<%xdN|%?bl<%xdI|%xdJ|%xdK|%xdL|%xdM>>;%t0.2%?bp<%xdN|%?bl<|%xdJ|%xdK|%xdL|%xdM>>;%t0.2%?bp<%xdN|%?bl<%xdI||%xdK|%xdL|%xdM>>;%t0.2%?bp<%xdN|%?bl<||%xdK|%xdL|%xdM>>

Kinda interested to know the difference.  It must make the battery symbol flash when charging or something...

[MarcGuay]

Kinda interested to know the difference.  It must make the battery symbol flash when charging or something...

Yeah it's a strange bit of code.  Seems like putting the %t code outside of the %?bp was the trick... Next time...