Question about the ipod brightness

[Sanek]

Rockbox is a wonderful OS, however I'm wondering why certain user-made patches have not been integrated into the current build. I'm inquiring about the brightness patch in particular for Ipod Video 5.5g.

To my knowledge, the brightness patch only causes bugs with 2 plugins - RockDoom and some other one (can't remember at the moment), however you can bypass it by increasing the brightness manually.

Without the brightness patch, the battery drains extremely fast since the screen is set at full brightness and I've noticed much shorter battery life before the need to recharge it with the screen on at all times running a plugin like RockDoom.

I'm just curious as to why not include the brightness patch in the current builds and set the brightness to max by default (perhaps put it into the debug menu).

The problem with applying the patch by yourself to every build is that some people just don't have the expertise/availability to do so (although myself not being one of them), so in order to take advantage of that particular patch, people have to use the unsupported 3rd-party builds which are often outdated.

Just seems like a very legitimate and useful addition, I'm surprised it wasn't added to the current build yet - at least for some targets.

Thank you in advance for the replies.

[Llorean]

Why isn't your question 'why don't patch authors follow through and do the work necessary to get it committed'. Also the iPod 5G has brightness these days.

[Sanek]

Why isn't your question 'why don't patch authors follow through and do the work necessary to get it committed'. Also the iPod 5G has brightness these days.

ahh I apologize, I didn't check the latest build, so I didn't notice that the brightness build was integrated already. Last official build I've used was a September build and brightness patch was not in there, so I guessed it wouldn't be in this one as well.

heh, I guess that just answered that particular question.  

While we're on the topic here, were the bugs relating to RockDoom and brightness patch fixed as well?

[Llorean]

The new method uses a different method of adjusting the brightness, and isn't actually based on that patch, and doesn't suffer from any of the same problems it had (or shouldn't).

[AlexP]

ahh I apologize, I didn't check the latest build, so I didn't notice that the brightness build was integrated already. Last official build I've used was a September build and brightness patch was not in there, so I guessed it wouldn't be in this one as well.

Which is why we require you try a current current build before reporting anything!