Rockbox Development > New Ports

SanDisk Sansa c200v2, m200v4, clipv1, clipv2, clip+, and fuzev2

<< < (113/386) > >>

kugel.:
Uhm, no, I had it set to A1 ("ldr   r1, [r0, #0x8]    /* it's A1 on C200 */"). What did you exactly change to make it work?

I suggest you do "svn diff rbutil/mkamsboot/ > patch.diff" and upload the file to the task (http://www.rockbox.org/tracker/task/9679). You can of course sent it to me by email or any other way of your choice (my email is: thomas47@arcor.de).

RockRabbit:

--- Quote from: kugel. on December 22, 2008, 06:17:27 PM ---Uhm, no, I had it set to A1 ("ldr   r1, [r0, #0x8]    /* it's A1 on C200 */"). What did you exactly change to make it work?

I suggest you do "svn diff rbutil/mkamsboot/ > patch.diff" and upload the file to the task (http://www.rockbox.org/tracker/task/9679). You can of course sent it to me by email or any other way of your choice (my email is: thomas47@arcor.de).

--- End quote ---

Apologies. Your code was fine. I did not pay enough attention to the code - i mistook the ifndef for an ifdef (not being familiar with the coprocessor and doing it in a rush). Forget I ever mentioned it - ignore the ramblings of an old man.

kugel.:
Ah ok, fine. I think you're right. Using #ifdef is better, as it's more clear. I also always expect #ifdef and don't pay much attention on whether there's an n between or not. Also #ifdef SANSA_C200V2 makes it just clearer what code is used for that target and what not.

Can you please give me a short sum up on what you changed? The memory stuff and...?

RockRabbit:
I think this is all I changed in total..

system-as3525.c
line 186+
moved the SANSA_C200V@ from the 8 mybtes group (next to the FUZE) to the 2 mbytes group (next to M200V4)
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
#if defined(SANSA_CLIP) || defined(SANSA_M200V4) || defined(SANSA_C200V2)
/* 16 bits external bus, low power SDRAM, 16 Mbits = 2 Mbytes */
#define MEMORY_MODEL 0x21

#elif defined(SANSA_E200V2) || defined(SANSA_FUZE)
/* 16 bits external bus, high performance SDRAM, 64 Mbits = 8 Mbytes */
#define MEMORY_MODEL 0x5
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/tools.configure
line 1761+
changed the memory= from 8 to 2
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   59|c200v2)
    target_id=55
    modelname="c200v2"
    target="-DSANSA_C200V2"
    memory=2 # wild guess
    arm9tdmicc
    bmp2rb_mono="$rootdir/tools/bmp2rb -f 0"
    bmp2rb_native="$rootdir/tools/bmp2rb -f 4"
    tool="$rootdir/tools/scramble -add=c2v2"
    output="rockbox.sansa"
    bootoutput="bootloader-c200v2.sansa"
    appextra="recorder:gui"
    plugins="yes"
    swcodec="yes"
    # toolset is the tools within the tools directory that we build for
    # this particular target.
    toolset=$scramblebitmaptools
    # architecture, manufacturer and model for the target-tree build
    t_cpu="arm"
    t_manufacturer="as3525"
    t_model="sansa-c200v2"
    ;;
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

/rbutil/mkamsboot/dualboot.s
line 124+
changed the cmp r1, #1 to cmp r1, #0
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
#elif defined(SANSA_C200V2)
        /* check for RIGHT on C6, should maybe changed to LEFT as soon as it
         * known in which pin that is in order for consistency  */
        ldr   r0, =GPIOC
        mov   r1, #0
        str   r1, [r0, #0x400]      /* set pin to output */

        ldr   r1, [r0, #0x100]      /* 1<<(6+2) */
        cmp   r1, #0                /* C6 high means button pressed */
        beq   boot_of
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

kugel.:
Thanks! That means I remembered correctly. I already put a new (supposedly final) patch on the task.

Good to know my patch didn't break other people's mp3 player ;)

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version