Support and General Use > Theming and Appearance Customization

wps not correctly showing on sansa e250r

(1/3) > >>

disorder:
I just got rockbox up and running no problem but now I am trying to install the "acotil" series themes and wps screens. the themes work fine, the wps screens however are not what they should be. they simply are the backdrop from the theme with very simple text displaying song info. it's as if the stock wps screen is there and the only things that changed were the font color and backdrop.

what could i be doing wrong?

NicolasP:
Your themes contain errors. Most probably, you're trying to use themes that use unsupported patches on an official build. You need to correct these themes or find corrected versions.

ONE_HUMAN:
I developed the Acotil theme.  It actually worked fine until some changes were made to the latest Rockbox builds.  My theme wasn't designed to be used with unsupported patches, and it was working with official builds... until recently, when how the %s and %m tags were used was changed.  I guess I'll have to rework my code.

I suspect the following lines in the .wps file are the problem:

%s%ac%?ia
%s%ac%?it


%s%acNext: %?It

I suppose that is now considered improper use of the %s tag, but I don't see why.  And I don't have any instances of the %m tag.

Or maybe it's the code for the progress bar:

%pb|height|0|176|184|

Have I improperly declared the margin?

By the way, if I make changes to the code to work with the newest builds of Rockbox, does that mean it will still work with older versions?  Or is it an either/or kinda thing?

Llorean:
Old WPSes that were compatible with SVN Rockbox _shouldn't_ have been broken by any of the recent changes, with a few exceptions. I believe the parser was made slightly stricter again, and I think the problem is that your pb seems kinda odd. It shouldn't have the word "height" in it, it should have the number of pixels of height the progress bar takes up. It may be that that's what's causing the problem. Which would qualify as a bug that your WPS had before, it just didn't get rejected for it at the time. Whatever problem you're having it's probably a bug your WPS had previously.

That being said, sometimes a change will be significant enough that you end up with an either/or situation (this one shouldn't be, strictly within the domain of unpatched SVN builds so long as you don't add a new tag that wasn't supported in older builds). But we try very hard not to break compatibility unless it's deemed very, very necessary (or with the recent %s -> %s with margins -> separate %s and %m where the change was in SVN for a very, very short time, then changed to something better almost immediately).

ONE_HUMAN:
Unfortunately I can't test this with Rockbox simulator rockboxui.exe because the latest version for the Sansa e200 is Nov. 13/07, while all other models are dated the 15th.  When I try to run the latest Rockbox firmware with the simulator, it generates errors and won't run correctly.  I guess I'll have to do it on the actual player.

I had a feeling it might be the code for my progress bar.  Hopefully replacing the word "height" with the number of pixels is enough to fix it.  Thanks.

Navigation

[0] Message Index

[#] Next page