Support and General Use > Theming and Appearance Customization

Album art and buffering

<< < (2/2)

dionoea:
Here it is (in apps/playback.c):

--- Code: ---#ifdef HAVE_ALBUMART
    if (tracks[track_widx].aa_hid < 0 && gui_sync_wps_uses_albumart())
    {
        char aa_path[MAX_PATH];
        if (find_albumart(track_id3, aa_path, sizeof(aa_path)))
            tracks[track_widx].aa_hid = bufopen(aa_path, 0, TYPE_BITMAP);
    }
#endif
--- End code ---

So bufopen() doesn't get called if the wps doesn't uses album art.

NicolasP:
dionoea got it right :) The bitmaps won't e buffered if you don't use an AA WPS. I think people who don't use AA would be angry if it was always buffered, and I would understand. If you change from a non-AA WPS to an AA WPS, the songs that were already buffered won't have their AA displayed, but the following ones will.

linuxstb:
Also, it's not just the buffering - it's also the searching the various directories and filenames for the .bmp file itself.  I don't think we want Rockbox to do that for every track if it doesn't need to (i.e. the WPS doesn't display the album art).

ell1ps1s:
Thanks, folks. That makes a lot of sense.
And thanks to the developers involved for doing it the clever way, rather than the obvious, easy way.  :)

Navigation

[0] Message Index

[*] Previous page