Album art and buffering

[ell1ps1s]

If a 'cover.bmp' file is present for the currently playing music file, is it always loaded to the buffer, or only if the current wps contains a %Cl tag?

[GodEater]

I'm pretty sure it'll always be loaded, regardless of the WPS.

[Llorean]

It really ought to be, otherwise you couldn't switch to an AA supporting WPS without rebuffering.

And it's not like we don't load the "Artist" tag if the WPS doesn't show "Artist" for example.

[GodEater]

I just don't imagine that the buffering code really cares about what WPS you're running. I'd be surprised if it was even aware of the WPS code at all.

[dionoea]

Nico_P could confirm, but I'm pretty sure that he included a function like wps_uses_album_art() which is called before buffering the bmp. You don't change WPS that often so I guess that it's not a problem if album art isn't buffered right after a WPS change.

[dionoea]

Here it is (in apps/playback.c):

Code: [Select]

#ifdef HAVE_ALBUMART
    if (tracks[track_widx].aa_hid < 0 && gui_sync_wps_uses_albumart())
    {
        char aa_path[MAX_PATH];
        if (find_albumart(track_id3, aa_path, sizeof(aa_path)))
            tracks[track_widx].aa_hid = bufopen(aa_path, 0, TYPE_BITMAP);
    }
#endif

So bufopen() doesn't get called if the wps doesn't uses album art.

[NicolasP]

dionoea got it right The bitmaps won't e buffered if you don't use an AA WPS. I think people who don't use AA would be angry if it was always buffered, and I would understand. If you change from a non-AA WPS to an AA WPS, the songs that were already buffered won't have their AA displayed, but the following ones will.

[linuxstb]

Also, it's not just the buffering - it's also the searching the various directories and filenames for the .bmp file itself.  I don't think we want Rockbox to do that for every track if it doesn't need to (i.e. the WPS doesn't display the album art).

[ell1ps1s]

Thanks, folks. That makes a lot of sense.
And thanks to the developers involved for doing it the clever way, rather than the obvious, easy way.