Should WPS Authors attempt to fix their themes?

[mschneider]

With all the new activity affecting wps code should authors make attempts to fix those themes affected that may no longer work? (I was thinking specifically of the scrolling margins themes that use the extra parameter)

[JdGordon]

they wont magically fix themselves..

[psycho_maniac]

I figured they wouldn't fix them because of the "scrolling margins" patch, but since that has been rejected they will have to be updated. i dont think that it will be very hard to do. I am editing one right now and it doesnt seem that hard. As long as you dont need a right margin that is.

[GodEater]

I figured they wouldn't fix them because of the "scrolling margins" patch, but since that has been rejected they will have to be updated. i dont think that it will be very hard to do. I am editing one right now and it doesnt seem that hard. As long as you dont need a right margin that is.

To be honest, I wouldn't expect these guys to fix them at all. Their WPS's have long made use of features that aren't in the core rockbox build because they like those features. So the scrolling margins patch not being accepted into svn isn't likely to convince them to change their nice themes now is it ?

[scarfy]

Is the scrolling margin patch related to the WPSs breaking?

I updated and noticed that pretty much all the WPSs on my Sansa no longer worked.

Should I wait for an issue to be resolved..? Or should I fix my WPS?

[GodEater]

If you want your WPS to work right now - then you have no choice but to fix it yourself. Waiting for something that no-one is guaranteed to do might mean you never getting the result you want.

[scarfy]

Yeah, sure, I understand that.

I was just curious to know what has changed to make the screens all break...?

[psycho_maniac]

Read the posts starting here. this will give you an idea what needs to be changed. http://forums.rockbox.org/index.php?topic=8933.msg103020#msg103020 this will show you how to fix the themes

[scarfy]

Cheers, guys... Managed to fix it now

[psycho_maniac]

i figurd id post info here as the other topic is all about AlbumArt. I have fixed these themes in the ipod video wiki and will work on more later. flamebox,  frostbox, naturebox, purpbox, RedGlassAA, blackglassAA, Cobalt, and slant, also added non album art versions of all the "box" themes (ie: flamebox)