Rockbox Development > New Ports

Phillips GoGear HDD6330

<< < (5/9) > >>

scallopedllama:
Define added and audio now works. Sound quality is certainly not on par with the OF.. I guess crunchy and quiet describes it ok.

Specifically I have an HDD6330 with the radio. I haven't tested everything yet though.

scallopedllama:
I'm pretty sure I figured the rest of this stuff out.
With the added define from the previous post, sound was working, but it wasn't very loud and the radio did not work. To fix those problems, the same kind of fix is needed as was needed to get audio working, adding a "|| defined(PHILIPS_HDD6330)" to a line.

For audio: /firmware/target/arm/wmcodec-pp.c at line 36
For the tuner: /firmware/drivers/tuner/tea5767.c at line 31
For the preamp: /firmware/drivers/audio/wm8731.c at line 204

With those three defines added, audio sound pretty good out of my hdd6330 and the radio works. The patch I submitted isn't very good, and the keymap is still pretty bad though. I have hopes for the code that h0hoon eventually commits.

I made diffs for these changes and put it in the tracker: http://www.rockbox.org/tracker/task/11417

funman:
I committed the patch, thanks

For the next patch please run svn diff from the root of your checkout so the full path to patched files is included in the patches

b0hoon:
scallopedllama: thanks for figuring out the rest of the audio problems!

Additionally i would like to change the behavior of the vertical scrollstrip, as it should be - sliding a finger down or up should scroll down or up the lists and menus (like in the OF), without the button_select in the middle (unnatural), which should be removed and remapped. The scrollstrip was designed to act like that IMO (it works great like that in the PB Vibe).

scallopedllama:
I agree with making the scrollstrip a scrollstrip and I would love to help out with that but I'd really like to see your code for properly using the scroll strip before starting. Can you get it committed or provide a patch?

EDIT: Working off of my scrollstrip enabled code, I basically took the code used in the pb vibe for scrolling and stuck it in here. It works, but not very well. Maybe because my original scrollstrip enabled code wasn't very good.

On an unrelated note, I noticed that the configure script indicated that the hdd6330 only has 32M of ram while the wiki page says it rocks 64M.

I attached a patch that will apply both of these changes from the latest trunk. It's not very good, but it's something..

As for other work to be done, the keymap still needs a lot of work... unless you already that. I also noticed that I can't boot into the OF. It gets to the line "hdd1630 key used" and freezes.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version