Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  User Interface and Voice
| | |-+  Quick settings
« previous next »
  • Print
Pages: [1]

Author Topic: Quick settings  (Read 4586 times)

Offline cc

  • Member
  • *
  • Posts: 51
Quick settings
« on: October 16, 2007, 10:10:45 AM »

I was thinking about the menu organisation, and I think that it's pretty good. The only problem I have is the number of menus I have to go though to get to some of the settings I use. I guess these particular settings are probably not the same ones everyone else wants... so, I thought it would be good to be able to copy the few settings I use regularly to a menu that could be accessed straight from the root menu - called "Quick Settings"? The size of the Quick Settings menu could probably be limited to some low number: 10?

What do people think? Sound useful? Dumb idea?

Note that it would only be individual settings (like "brightness"), not whole menus that could be accessed from this menu. Also the settings would still be available in the normal menus.

I have an idea of how I could implement this pretty cheaply: it would use the config file reading code, and the name of a setting followed by (say) a * would put the setting for it in the Quick Settings menu. I think it could work by just looking through the menus to find the menu_item_ex for that setting and putting a pointer to it into the Quick Settings menu. So, no extra data structures apart from the quick menu itself.

Other possibilities:

1) Allow users to configure it using the menus (not just the config file)  - maybe just a menu item at the end of each settings menu saying "Add to quick settings" (and afterwards a remove)

2) Putting the items at the end of the Settings (or root) menu instead of making  a new menu. OR allowing this option as well.

Any thoughts?
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Quick settings
« Reply #1 on: October 16, 2007, 10:17:38 AM »
Something like this has already been suggested, dozens of times.

Which settings do you change frequently? For example, with brightness, how many of the possible values do you use?

Why not use a few common setup config files?
Logged

Offline GodEater

  • Member
  • *
  • Posts: 2829
Re: Quick settings
« Reply #2 on: October 16, 2007, 11:52:08 AM »
Quote from: Llorean on October 16, 2007, 10:17:38 AM
Why not use a few common setup config files?

Which is what I do - and it works just fine...
Logged

Read The Manual Please

Offline cc

  • Member
  • *
  • Posts: 51
Re: Quick settings
« Reply #3 on: October 16, 2007, 12:00:04 PM »
Quote from: Llorean on October 16, 2007, 10:17:38 AM
Something like this has already been suggested, dozens of times.

Did anyone implement anything?

Quote
Which settings do you change frequently? For example, with brightness, how many of the possible values do you use?

Why not use a few common setup config files?

Yes, I use the config file route at the moment, but really I would prefer to be able to actaully adjust the brightness (edit: I mean so I can see it changing) . I also change the bookmark mode, the ff/rew speed settings, invert the screen, backlight timeout, the list gets kind of cluttered because you need one item for each value of each setting. And I would probably change more if it was easier.
« Last Edit: October 16, 2007, 12:05:46 PM by cc »
Logged

Offline nls

  • Developer
  • Member
  • *
  • Posts: 460
Re: Quick settings
« Reply #4 on: October 17, 2007, 04:47:03 AM »
Quote from: cc on October 16, 2007, 12:00:04 PM
Did anyone implement anything?

No, because most devs think it's a bad idea.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Quick settings
« Reply #5 on: October 17, 2007, 06:32:20 AM »
Quote from: nls on October 17, 2007, 04:47:03 AM
Quote from: cc on October 16, 2007, 12:00:04 PM
Did anyone implement anything?

No, because most devs think it's a bad idea.

I did implement it _ages_ ago (dont ask for the patch, its long gone), and im one of the few (only?) devs that love the idea..
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline nls

  • Developer
  • Member
  • *
  • Posts: 460
Re: Quick settings
« Reply #6 on: October 17, 2007, 01:40:33 PM »
ah, didn't know that, I'm not against this feature but I don't think I would use it that much, don't really need it.
Logged

Offline cc

  • Member
  • *
  • Posts: 51
Re: Quick settings
« Reply #7 on: October 18, 2007, 12:51:49 PM »

Thanks for the comments guys... of course I did it anyway  ;D

Came in at just 50 lines of code.

In the end I went for putting the items straight into the root menu, although it would be trivial to make it add to a dedicated menu or the settings menu instead/as well. The cfg file entries look like this:

Code: [Select]
# put frequently used settings into root directory
brightness: +root
invert: +root
autocreate bookmarks: +root
autoload bookmarks: +root
scan min step: +root

Logged

Offline cc

  • Member
  • *
  • Posts: 51
Re: Quick settings
« Reply #8 on: October 21, 2007, 04:48:22 PM »

I lived with it a bit, found some wrinkles and added a feature to let you put the menu that contains a setting (using *root).

The patch in the tracker: http://www.rockbox.org/tracker/task/8011

Here's a screenshot:



And the /.rockbox/fixed.cfg file:

Quote
brightness: +root
invert: +root
autoload bookmarks: *root
foreground color: *root
scan min step: +root
party mode: +root

Logged

Offline bluebrother

  • Developer
  • Member
  • *
  • Posts: 3421
  • creature
Re: Quick settings
« Reply #9 on: October 21, 2007, 04:59:07 PM »
While it's called root menu in the source (due to historical reasons) we don't consider having a root menu -- if that menu (the main menu) would be a root menu it would behave slightly different. So there is no root menu. Just for completeness.
Logged
Rockbox Utility development binaries (updated infrequently) · How to ask questions the smart way · We do not estimate timeframes.

Offline cc

  • Member
  • *
  • Posts: 51
Re: Quick settings
« Reply #10 on: October 21, 2007, 05:27:09 PM »

Heh, I had just managed to stop being confused by the main menu in the code being the settings menu  ;D

But I see your point, I have changed it to use +main and *main.
Logged

Offline bluebrother

  • Developer
  • Member
  • *
  • Posts: 3421
  • creature
Re: Quick settings
« Reply #11 on: October 21, 2007, 05:34:50 PM »
Thanks :)
Logged
Rockbox Utility development binaries (updated infrequently) · How to ask questions the smart way · We do not estimate timeframes.

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  User Interface and Voice
| | |-+  Quick settings
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.101 seconds with 14 queries.