Rockbox Development > Starting Development and Compiling

Developed a new patch (ID3 tag data in playlist rather than filename) - now...

<< < (2/3) > >>

bascule:
FS #6084

http://www.rockbox.org/tracker/task/6084

chiark:
Thanks! :)

hmm, that looks horribly familiar!  Weird that I couldn't find that - I suppose searching for ID3 and tagcache was the problem?  It appears that the author has written the bits around config changes, too.

I've never had garbage returned from the system, but it's good to see it's not me going mad with respect to dual calls of the routine.  There's a simple way around that though...

It seems there's no issue with performance providing stuff is in RAM: if I can check for that and not call the tag cache then there's no peformance issue (but there's no functionality, either :D )

bluebrother:

--- Quote from: chiark on October 05, 2007, 10:45:19 AM ---hmm, that looks horribly familiar!  Weird that I couldn't find that - I suppose searching for ID3 and tagcache was the problem?
--- End quote ---
There are quite some file types that don't use ID3 for metadata but something different ;)  (vorbis comments just comes in my mind)

polygonal:

--- Quote from: chiark on October 05, 2007, 10:45:19 AM ---Thanks! :)

hmm, that looks horribly familiar!  Weird that I couldn't find that - I suppose searching for ID3 and tagcache was the problem?  It appears that the author has written the bits around config changes, too.

I've never had garbage returned from the system, but it's good to see it's not me going mad with respect to dual calls of the routine.  There's a simple way around that though...

It seems there's no issue with performance providing stuff is in RAM: if I can check for that and not call the tag cache then there's no peformance issue (but there's no functionality, either :D )


--- End quote ---

I wonder about your patch. I wrote a similiar one for myself but the performance is horrible - seems to take forever for tagcache to retrieve info. What did you do exactly? (is your patch in FS?) The double call problem should be eliminatable as long as you don't ask for tag info in format_name, since the gui_list will possibly call that function more than once, especially there is a remote screen as well.

chiark:
hi, I am calling tagcache_fill_tags in the format_name routine.  It runs like a dog if the RAM cache is not enabled...

It's not in flyspray - I'll finish off the setting stuff before I put it in there.

Navigation

[0] Message Index

[#] Next page

[*] Previous page