Rockbox Development > Starting Development and Compiling

Developed a new patch (ID3 tag data in playlist rather than filename) - now...

<< < (3/3)

kendubya:
I've been thinking this could be done another way.
What if the tag information (artist and title) were written to the playlist itself during creation, then read back when needed?
Perhaps as a comment after each line.  For example:

/MUSIC/Some Artist - Some Song.mp3
#Some Artist - Some Song
/MUSIC/A badly named track.mp3
#Some Other Artist - Some other Song
/MUSIC/Another Artist - Another Song.mp3
#Another Artist  - Another Song
/ipod_control/FE35/AB67.aac
#An Artist from iTunes - A Song from iTunes

Presumably, rockbox would have to handle the situation where it  has not created the playlist and therefore doesn't have these comments to rely on, obviously falling back to listing just the filename.

I'm not sure if this would be practical, but I thought I'd throw it out there.

polygonal:

--- Quote from: chiark on October 12, 2007, 08:33:19 AM ---hi, I am calling tagcache_fill_tags in the format_name routine.  It runs like a dog if the RAM cache is not enabled...

It's not in flyspray - I'll finish off the setting stuff before I put it in there.

--- End quote ---

Then I don't see how your patch can be fast then (even for RAM cache), unless there are hardware differences between your DAP and mine. But I'll wait to see your patch (I assume it is quite close to the old patch in flyspray tha was closed?)


--- Quote from: kendubya on October 12, 2007, 08:45:49 PM ---I've been thinking this could be done another way.
What if the tag information (artist and title) were written to the playlist itself during creation, then read back when needed?
Perhaps as a comment after each line.  For example:

/MUSIC/Some Artist - Some Song.mp3
#Some Artist - Some Song
/MUSIC/A badly named track.mp3
#Some Other Artist - Some other Song
/MUSIC/Another Artist - Another Song.mp3
#Another Artist  - Another Song
/ipod_control/FE35/AB67.aac
#An Artist from iTunes - A Song from iTunes

Presumably, rockbox would have to handle the situation where it  has not created the playlist and therefore doesn't have these comments to rely on, obviously falling back to listing just the filename.

I'm not sure if this would be practical, but I thought I'd throw it out there.


--- End quote ---

There is already a playlist format (that is, not a new format but basic M3U plus comments) called EXTM3U that does what you are describing. There are widely available tools to convert normal M3U playlist to EXTM3U already (on the PC side), and a patch that implements this feature in rockbox is already is in flyspray.

As far as I understand, the current issue is with time but not implementation problem, since whatever method you go for to get title instead of filename, you will have to get the information somehow (either through database/tagcache or through reading the files, and both of the methods are unacceptably slow), unless you have an already-made playlist (then EXTM3U support should be competent and quick enough to solve the problem).

chiark:
Just FYI, my hardware is a 5.5g 30GB ipod...  That could explain the performance difference, maybe?

KindOfBlues71:
Any progress updates on this patch or is it dead as well?  I personally would rather create a playlist within Rockbox using my iTunes-loaded music files and be able to see the track names in that playlist.  I'd rather not deal with the hassle of connecting the iPod to my computer to convert a playlist to another format.  Unless, of course, there is no other way to do this, especially if there is a major performance issue.



--- Quote from: bluebrother ---There are quite some file types that don't use ID3 for metadata but something different ;)  (vorbis comments just comes in my mind)

--- End quote ---

Yet that doesn't make any difference for this patch (or the previous one) because they're iPod-specific and the default iPod firmware only supports WAV/MP3/AAC audio files.  Songs added to an iPod via iTunes are renamed something like TB6F.mp3 and located in a folder named F01, F02, etc.  These patches would allow those using iTunes the ability to see tracknames based on ID3 tags in Playlists rather than Apple's strange naming system.

-KindOfBlues71

Navigation

[0] Message Index

[*] Previous page