Why does playlist insert replace the current playlist when stopped?

[Llorean]

Try loading a ROM with Rockboy while music is playing (note: Only tested on Gigabeat, which will let you load some ROMs, but if they're too large will not because it needs the audio buffer to use for the larger ROMs).

As for the insert order thread, feel free to open another one, but as it looks like you've identified and fixed the bug in a patch, I'm not sure what further discussion is needed.

[cc]

Thanks, I'll take a look at rockboy.

As for the insert order thread, feel free to open another one, but as it looks like you've identified and fixed the bug in a patch, I'm not sure what further discussion is needed.

Yeah, I had some questions about how it worked, but I figured them out myself and did the patch.

 

[cc]

For anyone following this thread... I have made a patch to decouple the playlist editing from the play/stopped state:

 http://www.rockbox.org/tracker/task/7911

I thought about also getting rid of the stopped state completely (as was discussed earlier), but I could not figure out what all the implications of this might be, so I left it as is and just changed the playlist menu.

[Llorean]

Outside of my opinion as to whether the patch is necessary or not:

I really don't like the hiding of the "Insert" function, nor its renaming. Especially the renaming, honestly, the phrase "Insert in order" sounds bulky, and compared to "Insert Next" and "Insert Last" it's confusing why that one is named not for where, but how it's inserted. I think, especially with the hiding, you can preserve your goal while still leaving it named "Insert."

"Insert in Order" especially does not clear up any confusion about where "Insert" will place it, and just seems to suggest a parallel to "Insert Shuffled" which, I think, doesn't help the usability of it anyway.

[cc]

Yes, I struggled with the renaming, the accurate term was a bit recursive: Insert after the previous Insert next or previous Insert after the previous Insert next or...  

I thought "in order" because it inserts in order that you do the insertions. I thought "Insert ordered" was too close to "Insert shuffled" which is why I ended up with the more cumbersome "Insert in order". But, it is a tough call though whether using a more specific but potentially more confusing term is better than one that gives less of an idea but less chance of confusion.

I think the hiding when it isn't needed helps usability by making it easier to figure out what it is doing by trying it - there are less things to try and the commands don't do different things depending on whether it's the first time or not.

But it's a very simple patch and easy to take which ever bits you want and ignore the rest.

[Llorean]

Maybe "Insert After" or "Insert More"?

[cc]

I thought of "Insert After" , but then: after what?

But... "Insert more" I hadn't thought of... and think may be perfect!

[bascule]

'Insert Again' or 'Repeat Insert'?

[cc]

'Insert Again' or 'Repeat Insert'?

I considered those - in fact I used 'Insert again' until recently, but I thought they give the impression that the same stuff is going to be inserted as last time - confusing, maybe?

I'm still liking Llorean's "Insert more".

[Llorean]

I liked "More" the most too, of all the ones I could think of. It clearly suggests that the insert is in some way dependent upon the previously inserted files, so it's more intuitive that you'll be inserting after them. (At least to me.) Just because I'm against an idea doesn't mean I won't try to help make it a better idea that I still don't like.

[fml2]

in fact I used 'Insert again' until recently, but I thought they give the impression that the same stuff is going to be inserted as last time - confusing, maybe?

I'm still liking Llorean's "Insert more".

OTOH, 'Insert more' means to me that you have to choose what to insert after you've chosen this option. So, the most exactly phrase would probably be 'Insert this as well' (or something similar.)

[cc]

Heh, yeah I thought that too - but I'm hoping as it is a context menu the 'this' is kind of implied.

Anyway, changed the patch to "Insert more" and also tweaked to code a bit so now the binary size increase is down to 76 bytes (for the e200 build).

[dunno]

Insert This
Insert Chosen
Insert Music
Insert Selected
Add This
Add Chosen
Add Selected
Add to
Add Music

my .00002c worth

[GodEater]

Well that's not intuitive at all - I've no idea what the difference between all those is.

[cc]

Heh, does anyone have any comments on the new functionality itself rather than the strings?

The way I see it, the main advantages are:

- you can set up the current a playlist while stopped.
- it is understandable without reading the manual (apart from "queue" the meaning, but that is orthogonal to this patch)
- there are no side effects of play / stop as far as playlist editing is concerned
- All operations always do the same thing ('insert' does not do one of three different things
 depending on the internal state).

The disadvantages I see are:

- 76 bytes bigger binary
- it's different from how it works now
- more button presses if all you wanted to do was replace the current playlist and start playback (but then, there are easier ways of doing that).