Rockbox General > Rockbox General Discussion

Why does playlist insert replace the current playlist when stopped?

<< < (15/16) > >>

fml2:

--- Quote from: cc on October 10, 2007, 07:42:51 AM ---in fact I used 'Insert again' until recently, but I thought they give the impression that the same stuff is going to be inserted as last time - confusing, maybe?

I'm still liking Llorean's "Insert more".

--- End quote ---

OTOH, 'Insert more' means to me that you have to choose what to insert after you've chosen this option. So, the most exactly phrase would probably be 'Insert this as well' (or something similar.)

cc:

Heh, yeah I thought that too - but I'm hoping as it is a context menu the 'this' is kind of implied.

Anyway, changed the patch to "Insert more" and also tweaked to code a bit so now the binary size increase is down to 76 bytes (for the e200 build).

dunno:
Insert This
Insert Chosen
Insert Music
Insert Selected
Add This
Add Chosen
Add Selected
Add to
Add Music

my .00002c worth

GodEater:
Well that's not intuitive at all - I've no idea what the difference between all those is.

cc:

Heh, does anyone have any comments on the new functionality itself rather than the strings?

The way I see it, the main advantages are:

- you can set up the current a playlist while stopped.
- it is understandable without reading the manual (apart from "queue" the meaning, but that is orthogonal to this patch)
- there are no side effects of play / stop as far as playlist editing is concerned
- All operations always do the same thing ('insert' does not do one of three different things
 depending on the internal state).

The disadvantages I see are:

- 76 bytes bigger binary
- it's different from how it works now
- more button presses if all you wanted to do was replace the current playlist and start playback (but then, there are easier ways of doing that).

Navigation

[0] Message Index

[#] Next page

[*] Previous page