Rockbox General > Rockbox General Discussion
Why does playlist insert replace the current playlist when stopped?
Llorean:
Try loading a ROM with Rockboy while music is playing (note: Only tested on Gigabeat, which will let you load some ROMs, but if they're too large will not because it needs the audio buffer to use for the larger ROMs).
As for the insert order thread, feel free to open another one, but as it looks like you've identified and fixed the bug in a patch, I'm not sure what further discussion is needed.
cc:
Thanks, I'll take a look at rockboy.
--- Quote from: Llorean on October 07, 2007, 12:24:05 PM ---As for the insert order thread, feel free to open another one, but as it looks like you've identified and fixed the bug in a patch, I'm not sure what further discussion is needed.
--- End quote ---
Yeah, I had some questions about how it worked, but I figured them out myself and did the patch.
cc:
For anyone following this thread... I have made a patch to decouple the playlist editing from the play/stopped state:
http://www.rockbox.org/tracker/task/7911
I thought about also getting rid of the stopped state completely (as was discussed earlier), but I could not figure out what all the implications of this might be, so I left it as is and just changed the playlist menu.
Llorean:
Outside of my opinion as to whether the patch is necessary or not:
I really don't like the hiding of the "Insert" function, nor its renaming. Especially the renaming, honestly, the phrase "Insert in order" sounds bulky, and compared to "Insert Next" and "Insert Last" it's confusing why that one is named not for where, but how it's inserted. I think, especially with the hiding, you can preserve your goal while still leaving it named "Insert."
"Insert in Order" especially does not clear up any confusion about where "Insert" will place it, and just seems to suggest a parallel to "Insert Shuffled" which, I think, doesn't help the usability of it anyway.
cc:
Yes, I struggled with the renaming, the accurate term was a bit recursive: Insert after the previous Insert next or previous Insert after the previous Insert next or... ;D
I thought "in order" because it inserts in order that you do the insertions. I thought "Insert ordered" was too close to "Insert shuffled" which is why I ended up with the more cumbersome "Insert in order". But, it is a tough call though whether using a more specific but potentially more confusing term is better than one that gives less of an idea but less chance of confusion.
I think the hiding when it isn't needed helps usability by making it easier to figure out what it is doing by trying it - there are less things to try and the commands don't do different things depending on whether it's the first time or not.
But it's a very simple patch and easy to take which ever bits you want and ignore the rest.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version