Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  Embedded album art
« previous next »
  • Print
Pages: [1]

Author Topic: Embedded album art  (Read 3242 times)

zajacattack

  • Guest
Embedded album art
« on: September 22, 2007, 11:35:36 PM »
I want to know why embedded album art hasn't been implemented yet. A lot of mp3 players display embedded album art (e.g. iPod, Sansa). I have songs with embedded album art, and I don't know why rockbox hasn't been able to use them. Many original firmwares can.
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 8974
Re: Embedded album art
« Reply #1 on: September 22, 2007, 11:38:55 PM »
Rockbox doesn't support cover art, so embedded art is not supported either.  
Logged

Offline mikeage

  • Member
  • *
  • Posts: 110
    • mikeage.net
Re: Embedded album art
« Reply #2 on: September 22, 2007, 11:50:27 PM »
Quote from: zajacattack on September 22, 2007, 11:35:36 PM
I want to know why embedded album art hasn't been implemented yet. A lot of mp3 players display embedded album art (e.g. iPod, Sansa). I have songs with embedded album art, and I don't know why rockbox hasn't been able to use them. Many original firmwares can.

Probably because we're still waiting for you to write the patch that does it.

There's also the fact that standalone embedded art is waiting for the "metadata on bufffer" task to handle (arbitrary) supplemental data.

I assume that once that's ready, there might be some thought given to including embedded art instead of just standalone art.

It's also worth noting that embedded art is (always? usually?) JPG, and the main branch is still BMP only (the JPG viewer code has not yet been formally accepted)
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Embedded album art
« Reply #3 on: September 23, 2007, 02:32:10 AM »
Umm, the jpeg viewer works fine, and has since before there were color players. I don't know what you mean by "the JPG viewer code has not been formally accepted."

There is no jpeg decoding functions in the core, if that's what you meant, but the viewer has been around since the Archos days.
Logged

Offline mikeage

  • Member
  • *
  • Posts: 110
    • mikeage.net
Re: Embedded album art
« Reply #4 on: September 23, 2007, 03:22:03 AM »
I thought it was still a patch, not part of the distribution. Never mind.
Logged

Offline polygonal

  • Member
  • *
  • Posts: 64
Re: Embedded album art
« Reply #5 on: September 23, 2007, 08:59:37 AM »
Quote from: zajacattack on September 22, 2007, 11:35:36 PM
...A lot of mp3 players display embedded album art (e.g. iPod, Sansa).

Just a minor correction, ipod does NOT display embedded album art. It is itunes who pull all your embedded album art out of your files and lump them into a separate database file, and your ipod reads from that database file rather than the actual embedded album art. I suspect that other DAP that use their own database also do not read directly from the files.
Logged

Offline dana7

  • Member
  • *
  • Posts: 11
Re: Embedded album art
« Reply #6 on: September 23, 2007, 09:02:01 PM »
Just for the record, I could care less about album art on the player.  It is just a distraction, and I would disable it if given a choice.  I suspect many others would too.

My vote says spend the valuable developer time on things that improve the usability, stability, and sound quality.  
Logged

Offline LinusN

  • Member
  • *
  • Posts: 1914
Re: Embedded album art
« Reply #7 on: September 24, 2007, 03:24:18 AM »
I think embedded cover art would be a nice thing to support. It would make life a lot easier for the user.
Logged
Archos Jukebox 6000, Recorder, FM Recorder/iAudio X5/iriver H1x0, H3x0/Toshiba Gigabeat F20/iPod G5, G5.5

Offline pondlife

  • Developer
  • Member
  • *
  • Posts: 248
Re: Embedded album art
« Reply #8 on: September 24, 2007, 07:46:49 AM »
Hopefully, the Metadata-On-Buffer work that Nico_P's leading will both improve stability AND lead to album art support.  Everyone's a winner!

pondlife
Logged

Offline petur

  • Developer
  • Member
  • *
  • Posts: 769
  • wtb: time
Re: Embedded album art
« Reply #9 on: September 24, 2007, 08:07:19 AM »
couldn't the jpeg decoder be implemented as a codec so that it can be called briefly to load process the jpeg? Just a codec swap at startup after the first chunk of audio is decoded. Get the jpeg data from the MoB and dump the result there too?
Logged

Offline Gamesoul Master

  • Member
  • *
  • Posts: 16
Re: Embedded album art
« Reply #10 on: September 24, 2007, 09:17:21 AM »
For the record, I've seen embedded album art as both jpg and bmp format (not at the same time or in the same file, but you get what I mean). Though using bmp format for embedded art is about as intelligent as using a 1200x1200 image... both of which I've seen many times, unfortunately.
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  Embedded album art
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.123 seconds with 14 queries.