Rockbox General > Rockbox General Discussion

rockbox ported to motorola e680i/a780 by blackhawk from mfc

<< < (5/6) > >>

Llorean:
One of the big problems with that patch is that it contains several other patches (Album Art, BMP Resize, probably others) and also contains whitespace changes and files added that are irrelevant, so it requires someone to put in a bit of time and effort to decipher it.

LambdaCalculus:

--- Quote from: saratoga on September 13, 2007, 10:36:12 AM ---I think he means the source code has now been posted:

http://www.motorolafans.com/forums/download.php?id=6223

--- End quote ---

I was wondering why he just reposted the same link before, and didn't just post straight to this. Thanks for the link, saratoga!  :)

senab:

--- Quote from: Llorean on September 13, 2007, 10:40:44 AM ---One of the big problems with that patch is that it contains several other patches (Album Art, BMP Resize, probably others) and also contains whitespace changes and files added that are irrelevant, so it requires someone to put in a bit of time and effort to decipher it.

--- End quote ---

Can't you just patch the source with that patch, then patch -R all the other patches he's added ;)

You'd need to know what he's added though.

Llorean:
That assumes that the other changes he's made allows those patches to be removed cleanly. You'd need to know both which other patches he's installed, and which versions, and in what order, and so on. Then you have to weed out the extra fills (for example, .orig files that got included for some reason) and so on. There's just a lot of stuff there. :)

saratoga:
It looks like his SVN is a bit messed up, probably why he didn't want to post the patch right away.  

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version