Support and General Use > User Interface and Voice

Auto config loading or theme loading on mode switch...

<< < (5/5)

yegods:

--- Quote ---because if you treat "SYS_CHARGER_CONNECTED" as if it's only a car adapter thing, people plugging their players into the wall with car adapter mode disabled are still going to get affected by functionality that shouldn't happen.
--- End quote ---

i don't do that.  all functionality for the "car adapter mode" config swap is located in the car adapter mode processing function, _after_ it checks for the global.car_adapter_mode setting.

Llorean:
I didn't say you did do that, I said that it shouldn't be done, and differentiating between the sensing (which detects a charger insertion) and the action (the car adapter processing) keeps it clear where you're adding your code, and what is being done. And prevents confusion among other people.

yegods:
i've uploaded my patch.  i've been testing it for the last week, and it seems to work rather well.  here is the patch link:

http://www.rockbox.org/tracker/task/7716

Navigation

[0] Message Index

[*] Previous page