Support and General Use > User Interface and Voice

Auto config loading or theme loading on mode switch...

<< < (3/5) > >>

Febs:
To be fair, I think that his use of that term probably comes from the fact that we already call this feature "Car adaptor mode."

Llorean:
Yes, but there are other features focused around the charger insertion detection (backlight on when charger inserted, for example) that have nothing to do with car adapter mode. There is the one function for "car adapter processing" but this is not a sensor, this is a function that is called any time *any* charger is connected, and is in no way a car adapter sensor.

The sensor aspect is "charger inserted" rather than "car adapter inserted".

yegods:

--- Quote ---The sensor aspect is "charger inserted" rather than "car adapter inserted".
--- End quote ---

not quite true, since the SYS_USB_CONNECTED also functions as a "charger inserted", and SYS_CHARGER_CONNECTED is not called in that event (due to the boot into Apple FW?).  This may change when the Rockbox USB mode is in?

yes i realize the actual event is not for "car adapter mode", but the function that is called when the event occurs IS called "car_adapter_mode_processing", so that's the term i used.

Llorean:
Have you looked at the code for other players? I'm talking in a more abstract sense than "just iPods" and I fear you're thinking of them, since otherwise you'd be implying that all players have USB charging (they do not).

While car_adapter_mode_processing happens, it is not the only thing that happens when a charger is inserted and the charger is what is detected, not a car adapter.

yegods:
all the code for "car adaptor mode" is surrounded by #ifdef CONFIG_CHARGING... this includes the actual case statement for SYS_CHARGER_CONNECTED and SYS_CHARGER_DISCONNECTED... so it's pretty easy to see why they're related if not identical in my mind, and anyone's mind who has looked at the piece of the code.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version