Support and General Use > User Interface and Voice

Pressing LEFT to get to WPS from file root

<< < (11/45) > >>

TiMiD:
However, I think that a cleaner approach would be to simply avoid returning to wps if no song is loaded

then around line 1150

--- Quote ---        if (start_wps)
        {
            lcd_stop_scroll();
...

--- End quote ---

becomes

--- Quote ---        if (start_wps && audio_status()!=0)
        {
            lcd_stop_scroll();
...

--- End quote ---

hshah:
The tree.c file has now changed and this patch cannot be applied in the same way - any modification to the patch please?

LinusN:
Here's a working patch.


[attachment deleted by admin, too old]

hshah:
cool - thanks LinusN :D

XavierGr:
Well, here is my opinion about exiting and entering the wps:

Currently rockbox on iriver has 2 selection buttons. "Right" and "Single Joystick Down (click)".
This, IMHO, is a keymap waste.

I have made a patch that makes the single click button to both exit (as default) and enter the wps, no matter where the user is on the filetree.

So you hear a tune and want to check the filetree? Press click and you will exit the wps. Then if you want to get back to WPS you will press again joystick click and you are set.

I prefer this way because it is easy to remember and more easy for the hand. (this way you don't need to change hand position to reach the play button) Also I've set this for the radio too. (if you are outside the radio screen and press click you will be directed again to the radio screen.

Also another matter for me is the exit button of the Main menu. Currently when a user wants to exit the main menu, he will have to press one of the exit buttons which are 3! "Stop", "Left" and "A-B"(menu) buttons. All these buttons do the same thing exit the current menu screen and go to the upper menu level, but none of them can exit the menu immediately. So once again we could use the click to exit the menu immediately to where the user was before his entrance in the menu.

Only problem with that is that some may be confused, because many have in their minds that click == select.

Any comments, or further thoughts?

I will attach my patch here to test, it is only slight modification of the tree.c (I am not sure if it builds cleanly on latest build)



[attachment deleted by admin, too old]

Navigation

[0] Message Index

[#] Next page

[*] Previous page