Pressing LEFT to get to WPS from file root

[hshah]

Poo, this patch is no longer working for me.  Anyone know how to fix it?

[TiMiD]

Poo, this patch is no longer working for me.  Anyone know how to fix it?

just edit apps/tree.c and change this piece of code line 750 :

                if (!tc.dirlevel)
                    break;

with

                if (!tc.dirlevel && audio_status()!=0)
                {
                    /* if we are in / directory and a song is selected in the wps screen, jump to wps */
                    start_wps = true;
                    break;
                }

(i'm too lazy to make a new patch )

maybe this should be added to the cvs since it's very convenient and it's very unlikely this piece of code would generate a bug

[hshah]

I might modify that and remove the && audio_status()!=0 so that it always goes back to WPS regardless of the fact that it is playing a song!

[TiMiD]

I might modify that and remove the && audio_status()!=0 so that it always goes back to WPS regardless of the fact that it is playing a song!

I added && audio_status()!=0 to correct a small bug with this patch : when you start your player and when resume is off, the player is in the file browser program and then if you press back it goes to wps but nothing is displayed, the screen remains the same (you see files and directories) but since you are now in wps program, you are obliged to press the select button to go back to directories (I don't know if I explain clearly clear here)


audio_status() returns 0 when no song is loaded and others values wether a song is paused or playing ...

[hshah]

Ahh rite - ok

[TiMiD]

However, I think that a cleaner approach would be to simply avoid returning to wps if no song is loaded

then around line 1150

        if (start_wps)
        {
            lcd_stop_scroll();
...

becomes

        if (start_wps && audio_status()!=0)
        {
            lcd_stop_scroll();
...

[hshah]

The tree.c file has now changed and this patch cannot be applied in the same way - any modification to the patch please?

[LinusN]

Here's a working patch.


[attachment deleted by admin, too old]

[hshah]

cool - thanks LinusN

[XavierGr]

Well, here is my opinion about exiting and entering the wps:

Currently rockbox on iriver has 2 selection buttons. "Right" and "Single Joystick Down (click)".
This, IMHO, is a keymap waste.

I have made a patch that makes the single click button to both exit (as default) and enter the wps, no matter where the user is on the filetree.

So you hear a tune and want to check the filetree? Press click and you will exit the wps. Then if you want to get back to WPS you will press again joystick click and you are set.

I prefer this way because it is easy to remember and more easy for the hand. (this way you don't need to change hand position to reach the play button) Also I've set this for the radio too. (if you are outside the radio screen and press click you will be directed again to the radio screen.

Also another matter for me is the exit button of the Main menu. Currently when a user wants to exit the main menu, he will have to press one of the exit buttons which are 3! "Stop", "Left" and "A-B"(menu) buttons. All these buttons do the same thing exit the current menu screen and go to the upper menu level, but none of them can exit the menu immediately. So once again we could use the click to exit the menu immediately to where the user was before his entrance in the menu.

Only problem with that is that some may be confused, because many have in their minds that click == select.

Any comments, or further thoughts?

I will attach my patch here to test, it is only slight modification of the tree.c (I am not sure if it builds cleanly on latest build)



[attachment deleted by admin, too old]

[muesli]

i love that idea but cant test it due missing self compiling skills...

[XavierGr]

muesli: Here is my current build. It is not the latest but you can test the feature I am proposing.

http://www.misticriver.net/photos/displayimage.php?album=lastup&cat=11302&pos=0

[muesli]

i am currently running firefly's remote build excluding timid's changes. is that similar?

[blackreplica]

Can someone better versed in this give a noob an idea of how to implement linus' patch to allow me to go back to the wps by left click? Thanks in advance

[bluebrother]

you need to compile rockbox from sources ... See the Wiki on how to do this.