double click that button!

[yegods]

when researching a certain feature i wanted (Queue Album), i found that i needed a new type of button click to fit it into the WPS screen -- all the good ones were taken.  Double-Click seems very natural, and missing, so i implemented it.

here is the patch.  give it a try.  the patch is implemented for Ipod, and is not by default assigned to any buttons.  see my Queue Album patch for an example on how to assign to buttons.  it's also very simple to enable for other players.

Double Click:
http://www.rockbox.org/tracker/task/7555

Queue Album+
http://www.rockbox.org/tracker/task/7571

please post any relevant bug fixes or problems to those threads.

updated 8-22-07:
Double Click patch has been fixed and modified to allow click-clickhold functionality, and to set the desired double-click delay.  the delay is set under Settings-->General-->System-->Set Double-Click Delay

[yegods]

all i'm hearing are crickets for these features i've been uploading.  is it because no one else wants the features, or because you need me to upload my patched build?  just curious.

[DefineByte]

Personally I think double-clicking sounds like an excellent feature. I have no need for the queue albums patch though so I don't have much to say about it.

[elborak]

I didn't even look at the patch as I hate double clicking on a mouse and can only imagine it's worse on a handheld device. Personal taste issue.

[yegods]

i admit double-clicking is not the super-best solution, but if you think about the WPS, you'll see that it's got all the button combinations pretty much tied up.  i needed this functionality to be super easy to get at, since i'll be using it while driving mostly, so it had to be some sort of click on the WPS screen.

it actually works quite well with the ipod mounted.

thanks for the feedback though!

[Chronon]

I see how this could be useful.  I tend to listen by album a lot of the time anyway, though.  So queuing the entire album of the currently playing track is not something I do very much.  I can definitely see how this would be nice for those times when I'm listening to a large, shuffled playlist.  I'll have to see whether or not it's worth my time to modify these patches for my Gigabeat, though.  Kudos on making a patch to provide the functionality that you want, though!

[Llorean]

There are already some functions on short then long press of a button. How does this patch interact with those?

[yegods]

i spent a long time making sure that all current button functionality works just like it used to.  long and short presses are mostly unaffected by the patch.  necessarily there will be a very small pause before single click actions occur... this is due to waiting for a potential double-click.  it's very small, and i can't even notice it.

modifying the patch to work with other players is very simple, as described in the patch text.

[Llorean]

How does a short-long press work then? Does double click base itself on two button releases?

And how long, exactly, is the delay?

[yegods]

How does a short-long press work then? Does double click base itself on two button releases?

when a button is held down, it resets the double-click time, so that a double click will only be registered with two short clicks.  and yes, the double click gets queued after the second release of the button.

And how long, exactly, is the delay?

currently it's 20 ticks, and that seems to be about right, though it could probably be shortened a bit.  i wanted to leave some room for slow-ish double-clicks.

[DefineByte]

Maybe you could make the double-click time configurable, like on the PC.

[yegods]

i was thinking about doing that... one thing i wondered is: are the global_settings available in the firmware code?  it seems like they shouldn't be.  how do people configure firmware things?

i did a little research, and found that the default delay time is typically between 300 and 400 ms.

[JdGordon]

global_settings isnt accessable from, firmware/ look at how the backlight timeouts are set ...

[yegods]

global_settings isnt accessable from, firmware/ look at how the backlight timeouts are set ...

thanks for the tip.  i'll look into that.

[Mr_Grinch]

Double Click:
http://www.rockbox.org/tracker/task/7555

Queue Album+
http://www.rockbox.org/tracker/task/7571

please post any relevant bug fixes or problems to those threads.

updated 8-22-07:
Double Click patch has been fixed and modified to allow click-clickhold functionality, and to set the desired double-click delay.  the delay is set under Settings-->General-->System-->Set Double-Click Delay

This could be exactly what I'm looking for, I had my iriver stolen and purchased a second hand H320 from ebay. All seemed well but the Play button didn't work on the remote I got with it, so I figured the remote was bust. Not so, I tried my old one (which I knew worked) and same problem.

So I currently need to remap buttons (which should be fun being I've never really delved in to anything like this!) and your double click patch should help me get everything I want on to the remote.

Hopefully