Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Queue current track's album, Skip Album, Rewind Album patch
« previous next »
  • Print
Pages: [1] 2

Author Topic: Queue current track's album, Skip Album, Rewind Album patch  (Read 3916 times)

Offline yegods

  • Member
  • *
  • Posts: 71
Queue current track's album, Skip Album, Rewind Album patch
« on: August 13, 2007, 02:02:17 PM »
edited to add: currently these patches are Ipod Video only, but very easy to modify for supporting other players, as described in the patch text...

this is the feature i wanted most out of rockbox, and it wasn't there, so i whipped it up myself.  Please give it a try.  following are links to the two patches you need to install for the feature.  please report or fix bugs in the patches forum.  here is a description of the patch:

While in WPS screen, Double-clicking the OK button will queue the entire album of the currently playing track. it will then start playing the album from track 1.

While in WPS screen, double-clicking the right (ffwd) button will skip all track in the current album, and start playing on the first track of the playlist that is not the current album.

While in WPS screen, double-clicking the left (rewind) button will start playing the first track of the album currently playing... that it finds previous to the current track. in other words, it backs up one by one until it finds a track that isn't on the current album, and then plays the next track.

this is only enabled for Ipod Video currently. If you wish to enable this functionality for other players, then modify the Double Click patch to work with your player, as described in the Double Click patch post. Then modify this patch to work with your player, by adding the double click commands to the player's keymap c file, in the wps section. follow the same format and placement as in keymap-ipod.c.

patches required:

Double Click:
http://www.rockbox.org/tracker/task/7555

Album Mods:
http://www.rockbox.org/tracker/task/7571

« Last Edit: August 13, 2007, 02:18:58 PM by yegods »
Logged

Offline yegods

  • Member
  • *
  • Posts: 71
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #1 on: August 15, 2007, 01:15:13 PM »
strange... so silent about what i found to be a very desirable feature.  doesn't anyone listen to whole albums anymore?  is it a soundbyte world we live in?
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #2 on: August 15, 2007, 01:30:01 PM »
Well, for one thing, if you're in filetree mode, skipping albums is quite easy without any added code.

Secondly, please don't double post. See the forum posting guidelines.
Logged

Offline yegods

  • Member
  • *
  • Posts: 71
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #3 on: August 15, 2007, 01:56:25 PM »
this is needed for car mode, and i will be in WPS mode 99% of the time.  so it is not easy to skip an album.  PLUS, the mods give more than just skipping an album... they allow you to queue an album from the currently playing track.  meaning, you have a random play list, and you can play any album from the track that comes up, and then return to the play list after that album plays -- or (using my other mod) skip the album if you didn't really want to hear it.  cool eh?
Logged

Offline AlexP

  • Global Moderator
  • Member
  • *
  • Posts: 3688
  • ex-BigBambi
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #4 on: August 16, 2007, 01:05:35 PM »
It is incredibly easy to skip albums from the wps if you use filetree (like me!).
Logged
H140, F60, S120, e260, c240, Clip, Fuze v2, Connect, MP170, Meizu M3, Nano 1G, Android

Offline yegods

  • Member
  • *
  • Posts: 71
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #5 on: August 16, 2007, 04:00:22 PM »
what are the steps for skipping an album?
Logged

Offline Febs

  • Member
  • *
  • Posts: 2701
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #6 on: August 16, 2007, 04:53:36 PM »
Short press of the forward button followed by a long press.
Logged
Rockbox Forum Guidelines
The Rockbox Manual
How to Ask Questions the Smart Way
Please do not send me support questions via PM.

Offline miles_power

  • Member
  • *
  • Posts: 79
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #7 on: August 17, 2007, 10:24:12 AM »
What if when you pressed the skip button twice to skip an album but accidentally opened something you dident want to open at the same time?
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #8 on: August 17, 2007, 01:08:46 PM »
You can't "open something" from the WPS. So I'm not quite sure what you're asking.
Logged

Offline yegods

  • Member
  • *
  • Posts: 71
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #9 on: August 17, 2007, 02:39:11 PM »
Quote
Short press of the forward button followed by a long press.

are you talking about the WPS screen?  because according to the ipod wps context at least, that would skip the current track, and then do seek in the next track...  sounds like i'm missing something major, or you are :)
Logged

Offline Febs

  • Member
  • *
  • Posts: 2701
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #10 on: August 17, 2007, 02:43:23 PM »
In the time it took you to type that post you could have tried it and discovered I'm correct.

A short press of FF followed by a long press will move to the next folder.  Note that by "long press," I mean to press the button and then release it.  Obviously, if you continue to hold it down, that will seek.
Logged
Rockbox Forum Guidelines
The Rockbox Manual
How to Ask Questions the Smart Way
Please do not send me support questions via PM.

Offline yegods

  • Member
  • *
  • Posts: 71
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #11 on: August 17, 2007, 04:38:10 PM »
i didn't have my ipod at the moment.  but i have since tried it, and it doesn't work for me.  in fact, it enters some sort of seek mode, that i cannot get out of.  i have to reset the ipod to get out of it.
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #12 on: August 17, 2007, 04:44:03 PM »
Are you running an unpatched build of Rockbox, and using the directory advance functionality properly?
Logged

Offline yegods

  • Member
  • *
  • Posts: 71
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #13 on: August 17, 2007, 04:51:27 PM »
well, since i've never used that functionality before, i cannot guarantee i am using it correctly.  but i did a short press, following by a long press, and it went forward one track, and then into seeking mode.  from there i could seek in the track, but could not exit the seeking mode.

i will admit the possibility that the double-click code might be interferring with this functionality, but for the life of me, i cannot find the "advance directory" action in the ipod keymap code.  maybe you could point it out to me?  i.e. where is the action "advance directory" layed out in the key map -- keymap-ipod.c?  thanks!

nevertheless, and more to the point, my double-click implementation of "skip album" was only need by me because of the "queue track's album" which is the real feature of interest to me.  that feature is surely not done by the file tree wazzit.
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Queue current track's album, Skip Album, Rewind Album patch
« Reply #14 on: August 17, 2007, 04:53:44 PM »
So, you're testing with a patch that modifies button code?

For it to work, you need to be in the same conditions that the option for playback to go to the next directory when in filetree, no playlist, mode. You should be playing a single folder, by clicking on a song in the folder rather than by starting a playlist file or using insert/queue. It may be necessary that repeat is off. And it may be necessary that the option that lets it advance to the next folder at the end of the current one be enabled, though as I don't use this I'm not certain.
Logged

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Queue current track's album, Skip Album, Rewind Album patch
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.092 seconds with 14 queries.