Rockbox General > Rockbox General Discussion

Mpegplayer's "Display FPS" feature

(1/1)

Vortex:
Hi everyone,

I noticed something which made me think that maybe there is something wrong with the FPS calculation for the "Display FPS" feature in mpegplayer.

Basically the FPS counter changes more often at the beginning of a file, while it remains more stable towards the end. It also doesn't react quickly to framerate changes (like during scenes with a lot of movement compared to still frames).

This made me think that maybe the current implementation of the FPS counter simply divides the total amount of displayed frames by the current position in the file in seconds.
Thereby, the FPS counter shows the average FPS for the whole playback instead of the average FPS for the last second. (I just noticed that it kind of tells you that on the wiki page, but I didn't understand what it meant when I first read it).

I don't mind if this is the way the developers intended it to be, but I think that an FPS counter should display the "current" FPS (i.e. an average of the last second) and not the total average FPS.

Llorean:
The FPS counter is designed for a specific purpose, which is to benchmark the average playback speed. It's obvious that more complex bits are going to cause skipped frames and you can watch the skipped frames counter to know when it's happening.

So the FPS counter gives us a good idea overall how well the plugin is performing by giving a total average FPS. This is intentional.

Navigation

[0] Message Index