Rockbox General > Rockbox General Discussion

Raise tag size limit in database / tag parsers?

(1/1)

polygonal:
With the recently added tag fields, especially content grouping, the current tag size limit is unfortunately inadequate to accommodate a reasonable amount of information made possible by the supported tag fields. I imagine there is a hard-coded limit somewhere that is easy to change, but I don't know how changing the limit will impact rockbox in general. If I understand correctly, this should not impact users whose tag sizes are under the limit since the allocated tag size is not fixed by the limit.

Is it do-able? Does it constitute a valid (i.e. likely to be accepted) feature request? If so, I think I'll throw an entry on the tracker.

Thanks

Llorean:
As the data is statically allocated, at this time, it would indeed affect users whose tags were smaller than it.

Once Metadata on Buffer is included, the affect on users would be much less and probably make the matter less a subject of debate.

polygonal:
Sounds fair. I totally did not think about the audio buffer - was only thinking about the database. I think I found the line I want to change in the source code, so I will compile my own after I have time to set up a proper enviroment. Thanks.

Navigation

[0] Message Index