Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Rockbox General
| |-+  Rockbox General Discussion
| | |-+  Raise tag size limit in database / tag parsers?
« previous next »
  • Print
Pages: [1]

Author Topic: Raise tag size limit in database / tag parsers?  (Read 1153 times)

Offline polygonal

  • Member
  • *
  • Posts: 64
Raise tag size limit in database / tag parsers?
« on: August 11, 2007, 11:04:50 AM »
With the recently added tag fields, especially content grouping, the current tag size limit is unfortunately inadequate to accommodate a reasonable amount of information made possible by the supported tag fields. I imagine there is a hard-coded limit somewhere that is easy to change, but I don't know how changing the limit will impact rockbox in general. If I understand correctly, this should not impact users whose tag sizes are under the limit since the allocated tag size is not fixed by the limit.

Is it do-able? Does it constitute a valid (i.e. likely to be accepted) feature request? If so, I think I'll throw an entry on the tracker.

Thanks
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Raise tag size limit in database / tag parsers?
« Reply #1 on: August 11, 2007, 11:22:42 AM »
As the data is statically allocated, at this time, it would indeed affect users whose tags were smaller than it.

Once Metadata on Buffer is included, the affect on users would be much less and probably make the matter less a subject of debate.
Logged

Offline polygonal

  • Member
  • *
  • Posts: 64
Re: Raise tag size limit in database / tag parsers?
« Reply #2 on: August 12, 2007, 07:43:55 PM »
Sounds fair. I totally did not think about the audio buffer - was only thinking about the database. I think I found the line I want to change in the source code, so I will compile my own after I have time to set up a proper enviroment. Thanks.
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox General
| |-+  Rockbox General Discussion
| | |-+  Raise tag size limit in database / tag parsers?
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.066 seconds with 16 queries.