Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Recording
| | |-+  So how about getting the REP into svn?
« previous next »
  • Print
Pages: [1]

Author Topic: So how about getting the REP into svn?  (Read 2941 times)

Offline paulheu

  • Member
  • *
  • Posts: 213
So how about getting the REP into svn?
« on: July 31, 2007, 08:43:47 AM »
Last I remembered the Recording Enhancement Pack was not accepted due to some display handling issues before the (failed) 3.0 freeze.

What's the current status of this, I think most of the uncommited parts of this patch are actually useful and should IMO be included..

Could any of the powers that be shed some light on why not and if at all possible tell us what should be done to make it work..
Logged

Offline redwood

  • Member
  • *
  • Posts: 28
Re: So how about getting the REP into svn?
« Reply #1 on: July 31, 2007, 10:41:40 AM »
hear, hear.....would love to know what if anything is the holdup

Logged
jp

H120, H340, recording head

Offline linuxstb

  • Developer
  • Member
  • *
  • Posts: 1163
Re: So how about getting the REP into svn?
« Reply #2 on: July 31, 2007, 12:16:46 PM »
I don't know anything about the contents of the REP, but there are some general requirements for patches to be accepted:

1) They must be posted to flyspray.

2) Where possible, patches should be relatively small and self-contained and do one thing - the REP sounds like lots of patches rolled into one.  IMO these should be submitted for review and acceptance individually.

3) You need to find a developer (or developers) willing to commit these to SVN and take responsibility for any problems they may cause.
Logged

Offline petur

  • Developer
  • Member
  • *
  • Posts: 769
  • wtb: time
Re: So how about getting the REP into svn?
« Reply #3 on: July 31, 2007, 04:26:49 PM »
1) it is far from clear what is in the REP to date, I'm trying to sum up:
   - histogram
   - large peakmeters
   - custom button
   - ...

2) so as is evident, it is a lot of different stuff which will never make it in one go (I've been committing parts of it in the past though)

3) some things like the custom button are a bit controversial among the devs and will not make it anyway.

so.. lets do it this way:
1) make the definite list of patches that makes up the REP
2) decide on which ones should make it
3) extract and commit those
Logged

Offline paulheu

  • Member
  • *
  • Posts: 213
Re: So how about getting the REP into svn?
« Reply #4 on: July 31, 2007, 07:05:29 PM »
I agree with that.
Logged

Offline Davide-NYC

  • Member
  • *
  • Posts: 429
Re: So how about getting the REP into svn?
« Reply #5 on: August 01, 2007, 08:50:47 PM »
If I might give my opinion here for the record:

User fonts and custom sized peakmeters would be very much appreciated. Especially as the screen resolutions get higher and higher.

Being able to long press the record button on my H120 and go directly to the While Recording Screen from anywhere makes all of the sense in the world. The damn button is a RED DOT for the love of (insert deity of your choosing). Everywhere in the audio world a red dot means recording.  Often times this needs to be done with as little fuss as possible.  Has been committed!  ;D

I don't use the REP currently because I see it as being a bit "too much". I don't need a histogram nor do I need a graphic representation of the amount of disk and battery remaining. But I can see how they would be useful for some users.

I was a user of the REP a while back before certain features were committed to the main trunk.

My $0.02.  :)

PS: I have no opinion about the Countdown and Repeat timer features as I have never used them.
« Last Edit: August 02, 2007, 03:23:45 PM by Davide-NYC »
Logged
Currently: iRiver H132-RTC-CFMod

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: So how about getting the REP into svn?
« Reply #6 on: August 02, 2007, 08:01:52 AM »
You don't need to state which features you like. Features won't get in by users voting on them anyway.

What you need to do is break the REP into individual patches, one feature per patch, and get those patches up on the tracker and find out what problems they may cause for other targets.

So this begins with breaking the REP down into individual features.
Logged

Offline Magog

  • Member
  • *
  • Posts: 1
Re: So how about getting the REP into svn?
« Reply #7 on: September 06, 2007, 07:15:04 AM »
IMO the required functionality is simply :o to allow timed recording (of radio or line-in or mic, whatever) on the platforms that support it, perhaps via a list of start/stop/duration times. It'd be  great if the units could wake themselves up from off, but I'd be happy just to leave it powered on...

I'm not a developer so have no idea how difficult this'd be but I just bought an FM recorder with this in mind :'(

Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Recording
| | |-+  So how about getting the REP into svn?
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.112 seconds with 16 queries.