Support and General Use > Theming and Appearance Customization

100 Autoscore not showing properly in WPS

(1/1)

debar:
Can someone confirm this for me: when I have a track with a 100 autoscore, the autoscore shows as "10" instead of "100" in my wps.

bascule:
What player, what WPS/theme (post the code for the relevant bit). Looks like a formatting error, but with no information it's really hard to tell ;)

debar:
Sorry, I'm on a Gigabeat F.  I originally found the problem on a custom WPS I made for myself using Evil G's build w/ custom WPS line (FS#5900) code.

However I tried to modify a simpler WPS (one of the defaults that come preloaded on Rockbox, "Rockboxed" I think it's called) and just added the basic %ra code to display the autoscore, and tracks with '100' autoscore still show as '10'.

bascule:
Yes you are correct. However, I also found that two-digit autoscores were missing the last character, so I get (on Gigabeat F20 r13755):

Autoscore        Display
100                  10
 99                     9
 84                     8

The code where I think it is displayed from in /trunk/apps/gui/gwps-common.c looks OK to my untutored eyes...

case WPS_TOKEN_DATABASE_AUTOSCORE:
            if (intval)
                *intval = id3->score + 1;

            snprintf(buf, buf_size, "%d", id3->score);
            return buf;

I'll raise it as a bug. Raised as a bug: http://www.rockbox.org/tracker/task/7422

Navigation

[0] Message Index

Go to full version