Rockbox General > Rockbox General Discussion

New patch for support of WORK tag

<< < (2/4) > >>

safetydan:
Picard (the MusicBrainz tagger) suggets that GROUPING is the approriate Vorbis comment. See http://wiki.musicbrainz.org/PicardQt/TagMapping for details.

LinusN:
If the WORK/GROUPING tags are commonly used, I don't see why Rockbox couldn't use them. I mean, it's a fairly small change, to make some users happy.

dip:

--- Quote from: safetydan on June 21, 2007, 05:10:46 AM ---Picard (the MusicBrainz tagger) suggets that GROUPING is the approriate Vorbis comment. See http://wiki.musicbrainz.org/PicardQt/TagMapping for details.

--- End quote ---
Mp3Tag suggests CONTENTGROUP (see http://help.mp3tag.de/main_tags.html) and foobar2000 CONTENT GROUP (see http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:ID3_Tag_Mapping).

In fact, although the TIT1 field is often referred to as work tag I did not find a source which states that the vorbis comment is named WORK. So maybe I will support to read the CONTENTGROUP, CONTENT GROUP and GROUPING tags from the files to obtain high compatibility with different programs (similar as the albumartist patch reads ALBUMARTIST, ALBUM ARTIST and ENSEMBLE from vorbis comments). Since the official description for TIT1 in the id3 standard is "content group description" I will probably use CONTENTGROUP as WPS-tag to be used in tagnavi.conf (CONTENT GROUP is not possible due to the space inbetween the two words).

Any comments to that?

safetydan:
I'd say that the tag for tagnavi.conf purposes should be called 'grouping' as that's what it's doing. The word 'content' feels a bit redundant IMHO. But then again, I have no strong feelings either way since I wouldn't be using it.

As for what supporting multiple different tags, I don't see a problem with that. So long as it's a reasonable number of course. Don't forget to add the MP4 tags as well if you do a patch for this.

dip:

--- Quote from: safetydan on June 21, 2007, 06:32:42 AM ---I'd say that the tag for tagnavi.conf purposes should be called 'grouping' as that's what it's doing. The word 'content' feels a bit redundant IMHO. But then again, I have no strong feelings either way since I wouldn't be using it.
--- End quote ---
You definitly should! It's a great feature of Rockbox that you can browse for an album or a song even if you don't remember the name of the artist (which is not possible if you have an "artist/album/title" file structure. (Seems to be challenging to convince a developer to use the database  ;))


--- Quote ---As for what supporting multiple different tags, I don't see a problem with that. So long as it's a reasonable number of course. Don't forget to add the MP4 tags as well if you do a patch for this.

--- End quote ---
If MP4 tags must be handled separately from MP3 tags and Vorbis comments I am quite sure that they were not considered when ALBUMARTIST and COMMENT tag supprt was added to Rockbox (at least I did not add them in my previous patch). So I will have a look for the MP4 tags also into the ALBUMARTIST and COMMENT tags. I hope I will find the relevant places in the code...

BTW, during preparation of the WORK (or GROUPING) patch I also included the feature that in the Rockbox database the GROUPING tag is set to the value of the TITLE tag of a track if the GROUPING tag is not set in the music file. Otherwise you would either have to tag ALL your files with a GROUPING tag (even single music pieces NOT comprising of several movements, like e.g. small piano works as Beethovens "Für Elise") or when browsing through a tagnavi structure like "composer->work->artist->title" only multi part works would be shown.

The same is true for ALBUMARTIST so I think I will also make a separate patch that in the Rockbox database the ALBUMARTIST tag is set to the value of the ARTIST tag of a track if the ALBUMARTIST tag is not set in the music file. With this amendement it is no longer necessary to tag ALL your files with an ALBUMARTIST tag in order to have a browse structure like "albumartist->album->title" for ALL your albums. You need then only to tag the tracks of various artists albums with ALBUMARTIST=various or of albums for which ALBUMARTIST differs from ARTIST for another reason (e.g. albums of a certain artist on which e.g. one song is a duet with another artist (all songs except the duet have ARTIST=artist1 and the duet has ARTIST=artist1 & artist2).

Does that sound reasonable or are there any concerns to this additional feature? Of course, the original tags of the music files are not changed with this solution since the tags are only set in the internal Rockbox database.

Navigation

[0] Message Index

[#] Next page

[*] Previous page