Rockbox General > Rockbox General Discussion

New patch for support of WORK tag

<< < (3/4) > >>

Rincewind:

--- Quote from: dip on June 21, 2007, 10:35:15 AM ---The same is true for ALBUMARTIST so I think I will also make a separate patch that in the Rockbox database the ALBUMARTIST tag is set to the value of the ARTIST tag of a track if the ALBUMARTIST tag is not set in the music file. With this amendement it is no longer necessary to tag ALL your files with an ALBUMARTIST tag in order to have a browse structure like "albumartist->album->title" for ALL your albums. You need then only to tag the tracks of various artists albums with ALBUMARTIST=various or of albums for which ALBUMARTIST differs from ARTIST for another reason (e.g. albums of a certain artist on which e.g. one song is a duet with another artist (all songs except the duet have ARTIST=artist1 and the duet has ARTIST=artist1 & artist2).

Does that sound reasonable or are there any concerns to this additional feature? Of course, the original tags of the music files are not changed with this solution since the tags are only set in the internal Rockbox database.

--- End quote ---

This is great!
I only have the album artist tag for files that really need them and my foobar2000 is configured exactly in the way you describe it here.
If this gets commited I can finally use the database in rockbox in (almost) the same way as I use foobar2000.

dip:
I have added a patch for the above described improved ALBUMARTIST support at http://www.rockbox.org/tracker/task/7342

This patch now also supports ALBUMARTIST for MP4 and APE tags. Please try that since I do not have MP4 and files with APE tags so I couldn't test it.

I have also finished (but not yet put in the tracker) the second patch which adds support for a GROUPING tag as described. But I have the problem that both patches are changing lines at the same place in the original code so both patches apply when used only alone but as if you want to apply both patches one fails. How is this usually handled?

safetydan:
I've committed code that does a similar thing to what was described in FS# 7342. That should make it easier for you to focus on your grouping patch.

dip:

--- Quote from: safetydan on June 25, 2007, 07:48:29 AM ---I've committed code that does a similar thing to what was described in FS# 7342. That should make it easier for you to focus on your grouping patch.

--- End quote ---
Thanks a lot for the fast acceptance. I will revise my grouping patch accordingly.

One question: With the new version, will the %iA WPS tag be empty or set for a music file which has no albumartist tag set? With my original version it was set since the metadata was copied (and thus albumartist was even shown in the id3 info page). But if it is not set one could use a conditional in the wps file to decide if albumartist should be displayed or not in the WPS (since this makes only sense if it is different from the artist tag, otherwise two identical lines would be displayed).

safetydan:
The %iA tag will be empty if the track has no albumartist tag. Only the database is affected by the data copying.

Navigation

[0] Message Index

[#] Next page

[*] Previous page