Rockbox General > Rockbox General Discussion

New patch for support of WORK tag

(1/4) > >>

dip:
I am just preparing a new patch which will support an additional tag in the rockbox database for browsing and for the WPS. The tag is intended to be used for storing the "work" a track belongs to. This will be mainly used for classical music since the present ALBUM and TITLE tags are not sufficient to handle classical music. With the new tag it will for example be possible to save the album title of a CD comprising several symphonies to the ALBUM tag, the names of the symphonies to the new WORK tag and the titles of the movements of the symphonies to the TITLE tag. It will then be possible to create for example a browse structure like composer->work->artist->title in tagnavi.conf.

While for mp3 files the corresponding tags are defined as TIT1 (for id3v2.3 and 2.4) and TT1 (for id3v2.2) there seems to be no standard tag name for vorbis comments. I found several names (WORK, CONTENTGROUP, CONTENT GROUP, GROUPING) for mapping this id3 tag to vorbis comments but would appreciat if someone could point me to a reliable source indicating a name for the vorbis comment which is mostly used and can be considered to be a "standard" name.

fml2:
This is just my opinion but I'm not a developer so use with care :-) You can surely make a patch for this and put it to the tracker. But I'd say there's little to no chance that it will be committed because:

1. The tags are not standardized (as you say, and I agree), and I think the RB devs wouldn't want to stick to non standard tags

2. IIUC, every added tag significantly increases the bin size and used RAM size so only really needed tags are used

3. RB devs are not very fond of classical music, so they will probably be reluctant to addind something they don't need (there are also not many requests for this feature)

That said, I'd like to add that I would welcome such a feature since I have many classical pieces in my music collection (about 40%). But the problem is that the community (not only the RB one) has not agreed on the way to tag them. So the problem is not RB specific. See for example MediaMonkey forums on this topic.

dip:

--- Quote from: fml2 on June 21, 2007, 03:57:20 AM ---This is just my opinion but I'm not a developer so use with care :-) You can surely make a patch for this and put it to the tracker. But I'd say there's little to no chance that it will be committed because:
--- End quote ---
I previously put a patch to the tracker adding support for albumartist and comment tags which was committed almost immediately, so we will see.


--- Quote ---1. The tags are not standardized (as you say, and I agree), and I think the RB devs wouldn't want to stick to non standard tags
--- End quote ---
For mp3 files TIT1 and TT1 are standard tags and for vorbis comments as far as I understand no tags are really standard since you can use what you want. And albumartist was also no standard tag but the patch was committed. ;)


--- Quote ---2. IIUC, every added tag significantly increases the bin size and used RAM size so only really needed tags are used
--- End quote ---
Especially for classical music a WORK tag IS really needed to tag your music files in a way that they can be reasonably used.


--- Quote ---3. RB devs are not very fond of classical music, so they will probably be reluctant to addind something they don't need (there are also not many requests for this feature)
--- End quote ---
Don't blame the devs, they get older too and they may listen more to classical music ;) (of course it's not only a question of age).


--- Quote ---That said, I'd like to add that I would welcome such a feature since I have many classical pieces in my music collection (about 40%). But the problem is that the community (not only the RB one) has not agreed on the way to tag them. So the problem is not RB specific. See for example MediaMonkey forums on this topic.

--- End quote ---
I also use MediaMonkey (and Slimserver as well) and know about all these discussions about tagging of classical music. However, in my opinion all reasonable solutions require a further tag since with the ALBUM and TITLE tags there are only two tags available, bur for classical CDs comprising symphonies, sonatas or the like you NEED a third tag to map the relevant information.

Llorean:
Just as a note, you don't NEED tags to listen to music at all, so please be careful about using absolutes. Many people get by with their music organized solely in the filetree just fine, even including classical music.

dip:

--- Quote from: Llorean on June 21, 2007, 04:48:49 AM ---Just as a note, you don't NEED tags to listen to music at all, so please be careful about using absolutes. Many people get by with their music organized solely in the filetree just fine, even including classical music.

--- End quote ---
Sorry for being too absolute. Of course the tags are only needed if you use the database (and this is of course only my subjective opinion) and they will not help you anything and are not necessary when using the filetree.

Navigation

[0] Message Index

[#] Next page

Go to full version