Support and General Use > Theming and Appearance Customization

Allow upto 512 images on a WPS

<< < (6/10) > >>

NicolasP:
I don't see why we'd need brackets in the WPS syntax...
As of the different separator, I'm totally in favour of the idea and I like the semicolon.
I think the overloaded tag is better. It's not too hard to do and it feels better to use only one tag.
kahuna_999: I haven't had time to look at the patch, but I suggest you look at how the progressbar tag is parsed. IMHO it's quite a good way of treating this sort of tag that has a variable number of numerical parameters. Maybe we could even have a function dealing with it in a generic way...

PaulJam:

--- Quote from: NicolasP on June 15, 2007, 09:08:25 PM ---As of the different separator, I'm totally in favour of the idea and I like the semicolon.
--- End quote ---
Wouldn't using a semicolon as separator potentialy cause problems when used with alternating sublines?

Lear:

--- Quote from: PaulJam on June 16, 2007, 06:02:41 AM ---Wouldn't using a semicolon as separator potentialy cause problems when used with alternating sublines?

--- End quote ---

Indeed it would. Which is why I suggested ':'.

NicolasP:
Oh I'm sorry, I meant the colon. In fact I just wanted to say I agreed with Lear but I was a bit sleepy :)

kahuna_999:
patch re-sync'd in tracker.

I have changed the parm seperator to a colon as suggested, and re-implemented as an overloaded tag.

%xp<bitmap load id>:srcx:srcy:w:h
%xp<bitmap load id>:srcx:srcy:w:h:x:y

This no longer causes coding or readability issues.


--- Quote from: NicolasP on June 15, 2007, 09:08:25 PM ---kahuna_999: I haven't had time to look at the patch, but I suggest you look at how the progressbar tag is parsed. IMHO it's quite a good way of treating this sort of tag that has a variable number of numerical parameters. Maybe we could even have a function dealing with it in a generic way...

--- End quote ---
NichosP: Although the progressbar has optional parameters, it still uses a '|' (upright) as the parameter seperator, so if this was used in a conditional, the same issues would arise.
As for a generic function...  Each tag is parsed individually, so not a great deal of use for that.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version