Support and General Use > Theming and Appearance Customization

Allow upto 512 images on a WPS

<< < (5/10) > >>

kahuna_999:
I am happy to go with the majority decision on this.

1. Keep the current separators ( | ) and have the two tags.
or
2. Switch to a comma separator, and have one overloaded tag.  

Would it be acceptable to change the tag syntax for this one tag?  This would go against the wps ‘standard’ already in place.  
This is a decision for the ‘core’ dev team to make, not for me and my first patch  ;)

imho I think it would make sense to have tag parameters separated by a comma, and aim to change the syntax of all parameterised tags over time.

In the short, term there would be a non-consistent syntax for wps tags, but long term it would be easier to include more conditional options without the problems encountered here.

Lear:
A comma separator is not so good, I think. Several tags include filenames, and a comma is perfectly valid in a filename. What about colon (':')?

The existing standard isn't good enough for general use, so something new is needed. I'd even vote against applying this patch with '|' as a separator.

lowlight:
FWIW...

I have a similar concept kind of working that utilizes "icon" bitmaps, i.e. a vertical strip of images. This is the same format used for custom icons, and thus, reuses that code. My idea was to have a single iconset that could be used for common enumerations like volume, battery, codec, etc.

For instance, to custom volume graphic with 10 states needs:
-- 10 bmps
-- 10 %xl loads
-- use something like %pv

Using an iconset for the same thing, you need:
-- 1 bmp containing all the "icons" in a vertial strip
-- 1 %xl load (also specifing the number of icons in the file)
-- use 1 command like %evA (enumerate volume with image A)

I think this would greatly simplify the readibility of WPS's. Not to mention speed up the parsing of the wps and loading of images.

I've got it hacked into an older svn tree, so when I clean up my code, I'll post it on the tracker.

Lear:
I like that idea. It isn't as flexible, but it still frees lots of images and can simplify the wps files noticeably.

robin0800:

--- Quote from: kahuna_999 on June 14, 2007, 05:47:05 AM ---I am happy to go with the majority decision on this.

1. Keep the current separators ( | ) and have the two tags.
or
2. Switch to a comma separator, and have one overloaded tag.  

Would it be acceptable to change the tag syntax for this one tag?  This would go against the wps ‘standard’ already in place.  
This is a decision for the ‘core’ dev team to make, not for me and my first patch  ;)

imho I think it would make sense to have tag parameters separated by a comma, and aim to change the syntax of all parameterised tags over time.

In the short, term there would be a non-consistent syntax for wps tags, but long term it would be easier to include more conditional options without the problems encountered here.


--- End quote ---

If You need an extra character why not use brackets ( ) these are not accepted by the wps parser at present but it should be a simple change for the paser to accept them even if at first it doesn't action them.
This would mean they would be to aid clarity in writing only.
Perhaps at a later date proper bracket handling could be done.

Navigation

[0] Message Index

[#] Next page

[*] Previous page