Rockbox Development > Starting Development and Compiling

Problems applying Scrolling Margins and Album Art Patch

(1/1)

ldmes:
Hi! I'm kind of new to this (I had a fellow rockbox user compile a custom build for me, but now want to be able to update it on my own), and have had problems applying the following patches:

album_art_20070426.patch
scroll-margins_2007426.patch

I also had the progressbar_ycoord_rewrite.patch applied to that customn build, but I read that it has now been commited to and is a part of Rockbox.
I would be totally golden if they added the two other patches as well, but for now if I can get some help with this it would be great.

I downloaded the current SVN version of Rockbox to C:\Rockbox\Home\Guest\rockboxMMDDYY\rockbox (have the 05/27/2007 version) and then drop the patch files into that directory. Then I went into CYGWIN and cd .. to that directory and then did the patch --binary -p0 < patchfilename.patch command and every hunk said it failed for both patches.

When I first installed CYGWIN and SVN, I downloaded at the time the current version of rockbox and compiled it to make sure everything was working, before attempting to patch files. And yes I am trying to patch the files to NON-COMPILED files.

I have read on the Flyspray patch pages for those patches that people are able to patch these patches, so I wondering what I may be doing wrong? Or are those patches now not compatible with the current SVN version of Rockbox?

Mikerman:
It could simply be that the patch files are out of sync with the current Rockbox code.

Did you try increasing the p value 1 by 1 up to 3 or so (that at least used to be explained in the Simple Guide to Compiling instructions)?

I also sometimes have had luck in placing a patch in the directories to which it will be applied (note:  this sometimes will be multiple directories for a patch--open the patch and scroll through it to see where it will be applied), use cd to change to the directories, and apply the patch command in those directories.

Finally, you can open the patch up and see what needs to be modified, and then go into the files to be modded manually, and make the changes yourself.  Although it sounds a bit intimidating, it can be done fairly easily if the patch is not too complex--an editor's text search function is your friend here.

Navigation

[0] Message Index