Rockbox General > Rockbox General Discussion

[iPod Nano] Bookmarks not working

<< < (2/3) > >>

dflachbart:

--- Quote from: GodEater on June 11, 2007, 10:44:50 AM ---
It'll happen when someone works on it - we never make estimates for when anything gets done in Rockbox, because the developers ALL work in their spare time - and no-one can ever predict when "real life" will intrude on their Rockbox work, or if they'll simply lose interest in it.

--- End quote ---

Of course I fully understand what you are saying (being a dev myself...). My main intention was to find out if this is a feature that is deemed "desirable" by the Rockbox team, or if there maybe aren't any plans at all for this.

Thanks,
Dirk

GodEater:
Oh, I think it's definitely deemed desirable - it'll be the implementation that'll be argued about - not the feature :)

dflachbart:
 ;D

dflachbart:
Well, I noticed that this feature is only scheduled for 3.1, so I went ahead and looked at the bookmark code myself. I hacked the 'create_bookmark' function to use the folder name of the song as the playlist name if the current playlist name is empty, and also made sure that 'system_check' does not return false in this case.

This seems to generate the same bookmark as if the song has been played from the file view. Since I am new to the rockbox code (and my C is a bit rusty) it is absolutely possible that this change has side effects which I can't oversee right now, but all I can say is that it is working fine for my own purposes (on 80G ipod).

I doubt that such a "dirty hack" is worth putting on the patch tracker though...


Dirk

GodEater:
It's always worth putting on the patch tracker - even if the code is horrid, it's a starting point for someone else to have a go at tidying up and improving it.

Navigation

[0] Message Index

[#] Next page

[*] Previous page